Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing output format for analyze_vars_in_col #48

Merged
merged 8 commits into from
Jun 6, 2023
Merged

Fixing output format for analyze_vars_in_col #48

merged 8 commits into from
Jun 6, 2023

Conversation

Melkiades
Copy link
Contributor

Coming from insightsengineering/tern#938. Adapts the tests.

@BFalquet FYI, to modify in chevron accordingly

@Melkiades Melkiades added the enhancement New feature or request label Jun 5, 2023
@Melkiades Melkiades requested a review from edelarua June 5, 2023 16:50
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023 •
edited
Loading

Unit Tests Summary

    1 files  112 suites   2m 42s ⏱️
246 tests 235 ✔️   11 💤 0 ❌
495 runs  250 ✔️ 245 💤 0 ❌

Results for commit 4bcd3df.

♻️ This comment has been updated with latest results.

edelarua
edelarua approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@edelarua edelarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@Melkiades Melkiades merged commit c560234 into main Jun 6, 2023
@Melkiades Melkiades deleted the 931_reinstate_summarize_vars_in_cols@main branch June 6, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edelarua edelarua edelarua approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Melkiades @edelarua