Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics tracing tags #1626

Merged
merged 24 commits into from
Dec 6, 2023
Merged

Metrics tracing tags #1626

merged 24 commits into from
Dec 6, 2023

Conversation

EddeCCC
Copy link
Member

@EddeCCC EddeCCC commented Dec 4, 2023

Include metrics tags also in tracing


This change is Reviewable

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Merging #1626 (0b0a18b) into master (d3a9f36) will increase coverage by 0.21%.
Report is 1 commits behind head on master.
The diff coverage is 88.85%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1626      +/-   ##
============================================
+ Coverage     78.38%   78.59%   +0.21%     
- Complexity     2519     2579      +60     
============================================
  Files           257      266       +9     
  Lines          8257     8453     +196     
  Branches        984      995      +11     
============================================
+ Hits           6472     6643     +171     
- Misses         1358     1376      +18     
- Partials        427      434       +7     
Files Coverage Δ
...ocelot/commons/models/health/AgentHealthState.java 100.00% <100.00%> (ø)
...t/ocelot/config/model/metrics/MetricsSettings.java 50.00% <ø> (ø)
...l/metrics/definition/MetricDefinitionSettings.java 100.00% <ø> (ø)
...t/ocelot/config/model/tracing/TracingSettings.java 100.00% <ø> (ø)
...core/command/handler/impl/LogsCommandExecutor.java 85.00% <ø> (ø)
...elot/core/exporter/OtlpMetricsExporterService.java 70.49% <ø> (ø)
...tation/config/MethodHookConfigurationResolver.java 96.18% <100.00%> (ø)
...core/instrumentation/hook/MethodHookGenerator.java 87.59% <100.00%> (+1.64%) ⬆️
.../instrumentation/hook/actions/MetricsRecorder.java 100.00% <100.00%> (ø)
...n/hook/actions/span/ContinueOrStartSpanAction.java 95.56% <ø> (ø)
... and 17 more

... and 1 file with indirect coverage changes

@EddeCCC
Copy link
Member Author

EddeCCC commented Dec 4, 2023

Only the last four commits are relevant for this PR's feature.

@EddeCCC EddeCCC requested a review from TitusLabs December 4, 2023 14:15
Copy link
Contributor

@TitusLabs TitusLabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 9 files at r1, 8 of 23 files at r2, 7 of 255 files at r3, 212 of 240 files at r4, 9 of 10 files at r5, 33 of 35 files at r6, 5 of 5 files at r7, 7 of 7 files at r8, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @EddeCCC)

@EddeCCC EddeCCC merged commit 219f9ed into master Dec 6, 2023
17 checks passed
EddeCCC added a commit that referenced this pull request Dec 7, 2023
EddeCCC added a commit that referenced this pull request Dec 8, 2023
@EddeCCC EddeCCC deleted the metrics-tracing-tags branch January 9, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants