Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Metrics tracing tags" #1628

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Conversation

EddeCCC
Copy link
Member

@EddeCCC EddeCCC commented Dec 7, 2023

Reverts #1626 since the PR #1625 should be merged first


This change is Reviewable

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #1628 (dec01d1) into master (219f9ed) will decrease coverage by 0.18%.
The diff coverage is 94.59%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1628      +/-   ##
============================================
- Coverage     78.56%   78.38%   -0.18%     
+ Complexity     2578     2519      -59     
============================================
  Files           266      257       -9     
  Lines          8453     8257     -196     
  Branches        995      984      -11     
============================================
- Hits           6641     6472     -169     
+ Misses         1377     1358      -19     
+ Partials        435      427       -8     
Files Coverage Δ
...t/ocelot/config/model/metrics/MetricsSettings.java 50.00% <ø> (ø)
...l/metrics/definition/MetricDefinitionSettings.java 100.00% <ø> (ø)
...nfig/model/selfmonitoring/AgentHealthSettings.java 0.00% <ø> (ø)
...t/ocelot/config/model/tracing/TracingSettings.java 100.00% <ø> (ø)
...core/command/handler/impl/LogsCommandExecutor.java 85.00% <ø> (ø)
.../propertysources/http/HttpConfigurationPoller.java 84.00% <100.00%> (+2.52%) ⬆️
...elot/core/exporter/OtlpMetricsExporterService.java 70.49% <ø> (ø)
...tation/config/MethodHookConfigurationResolver.java 96.18% <100.00%> (ø)
...core/instrumentation/hook/MethodHookGenerator.java 85.95% <100.00%> (-1.64%) ⬇️
.../instrumentation/hook/actions/MetricsRecorder.java 100.00% <100.00%> (ø)
... and 8 more

... and 2 files with indirect coverage changes

@EddeCCC EddeCCC merged commit b204add into master Dec 8, 2023
16 checks passed
@EddeCCC EddeCCC deleted the revert-1626-metrics-tracing-tags branch December 13, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant