AWS VPC Peering and Security Group Firewall rule cluster resources enhancement #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worryg0d
requested review from
ribaraka,
testisnullus,
tengu-alt and
OleksiienkoMykyta
testisnullus
approved these changes
Sep 19, 2023
ribaraka
requested changes
Sep 19, 2023
Comment on lines
21
to
23
| "errors" | ||
|
|
||
| "github.com/go-logr/logr" |
| if err != nil { | ||
| return err | ||
| } | ||
| } | ||
|
|
||
| if awsPeering.Annotations[models.UpdateQueuedAnnotation] == "" && |
There was a problem hiding this comment.
how about using the UpdatingEvent annotation?
There was a problem hiding this comment.
It makes sense. Good catch, thanks. Fixed
| aws.Annotations[models.UpdateQueuedAnnotation] = models.True | ||
| err = r.Patch(ctx, aws, patch) | ||
| if err != nil { | ||
| l.Error(err, "Cannot patch AWS VPC Peering resource metadata with update queued annotation", | ||
| "AWS VPC Peering ID", aws.Status.ID, | ||
| ) | ||
| r.EventRecorder.Eventf( | ||
| aws, models.Warning, models.PatchFailed, | ||
| "Patching resource with update queued annotation is failed. Reason: %v", | ||
| err, | ||
| ) | ||
|
|
||
| return models.ReconcileRequeue | ||
| } | ||
|
|
||
| err = r.API.UpdatePeering(aws.Status.ID, instaclustr.AWSPeeringEndpoint, &aws.Spec) |
worryg0d
force-pushed
the
aws-vpc-external-changes-handling
branch
2 times, most recently
from
967000c
to
fd2c1bf
Compare
ribaraka
approved these changes
Sep 19, 2023
tengu-alt
approved these changes
Sep 19, 2023
worryg0d
force-pushed
the
aws-vpc-external-changes-handling
branch
from
fd2c1bf
to
3c564a2
Compare
taaraora
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done: