Set deployment status to inactive on missing status #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This was referenced Sep 22, 2022
This comment has been minimized.
This comment has been minimized.
This was referenced Sep 22, 2022
This comment has been minimized.
This comment has been minimized.
This was referenced Sep 22, 2022
int128
changed the title
This comment has been minimized.
This comment has been minimized.
This was referenced Sep 22, 2022
This comment has been minimized.
This comment has been minimized.
This was referenced Sep 22, 2022
diff
e2e_test/applications/argoproj.io_v1alpha1_application_app1.yaml--- a/tmp/kustomize-action-YLcz5y/e2e_test/applications/argoproj.io_v1alpha1_application_app1.yaml
+++ b/tmp/kustomize-action-hIWSDB/e2e_test/applications/argoproj.io_v1alpha1_application_app1.yaml
@@ -1,6 +1,10 @@
apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
+ finalizers:
+ - resources-finalizer.argocd.argoproj.io
+ labels:
+ int128.github.io/e2e-test: fixture
name: app1
namespace: argocd
spec:e2e_test/applications/argoproj.io_v1alpha1_application_app2.yaml--- a/tmp/kustomize-action-YLcz5y/e2e_test/applications/argoproj.io_v1alpha1_application_app2.yaml
+++ b/tmp/kustomize-action-hIWSDB/e2e_test/applications/argoproj.io_v1alpha1_application_app2.yaml
@@ -1,6 +1,10 @@
apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
+ finalizers:
+ - resources-finalizer.argocd.argoproj.io
+ labels:
+ int128.github.io/e2e-test: fixture
name: app2
namespace: argocd
spec:e2e_test/applications/argoproj.io_v1alpha1_application_app3.yaml--- a/tmp/kustomize-action-YLcz5y/e2e_test/applications/argoproj.io_v1alpha1_application_app3.yaml
+++ b/tmp/kustomize-action-hIWSDB/e2e_test/applications/argoproj.io_v1alpha1_application_app3.yaml
@@ -1,6 +1,10 @@
apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
+ finalizers:
+ - resources-finalizer.argocd.argoproj.io
+ labels:
+ int128.github.io/e2e-test: fixture
name: app3
namespace: argocd
spec: |
This was referenced Sep 22, 2022
int128
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem to solve
When an actual resource has been deleted by the Application finalizer, the deployment is still success (Active).
How to solve
Application health status becomes Missing when the finalizer cleans up. It sets the deployment status to inactive (Destroyed).