Set deployment status to inactive on missing status

.github/workflows/docker.yaml

@@ -137,6 +137,8 @@ jobs:
           DEPLOYMENT_URL: ${{ steps.deployment-app3.outputs.url }}
           GITHUB_TOKEN: ${{ steps.octoken.outputs.token }}
 
+      - run: make -C e2e_test delete-apps
+
       # show logs
       - run: make -C e2e_test logs-argocd
         if: always()

controllers/applicationhealthdeployment_controller.go

@@ -105,6 +105,8 @@ func (applicationHealthDeploymentComparer) Compare(applicationOld, applicationNe
 	case health.HealthStatusHealthy, health.HealthStatusDegraded:
 		lastNotifiedDeploymentURL := applicationNew.Annotations[annotationNameOfLastDeploymentOfHealthy]
 		return currentDeploymentURL != lastNotifiedDeploymentURL
+	case health.HealthStatusMissing:
+		return true
 	}
 	return false
 }

e2e_test/Makefile

@@ -55,6 +55,9 @@ deploy-app3:
 	$(MAKE) -C $(FIXTURE_DIR) update-manifest-app3
 	go run ./waitforapp -revision "`git -C $(FIXTURE_DIR) rev-parse $(FIXTURE_BASE_BRANCH)`" app3
 
+delete-apps:
+	kubectl -n argocd delete applications -l int128.github.io/e2e-test=fixture
+
 logs-controller:
 	-kubectl -n argocd-commenter-system logs -l control-plane=controller-manager --all-containers --tail=-1
 logs-argocd:

e2e_test/applications/app1.yaml

@@ -3,6 +3,10 @@ kind: Application
 metadata:
   name: app1
   namespace: argocd
+  labels:
+    int128.github.io/e2e-test: fixture
+  finalizers:
+    - resources-finalizer.argocd.argoproj.io
 spec:
   project: default
   source:

e2e_test/applications/app2.yaml

@@ -3,6 +3,10 @@ kind: Application
 metadata:
   name: app2
   namespace: argocd
+  labels:
+    int128.github.io/e2e-test: fixture
+  finalizers:
+    - resources-finalizer.argocd.argoproj.io
 spec:
   project: default
   source:

e2e_test/applications/app3.yaml

@@ -3,6 +3,10 @@ kind: Application
 metadata:
   name: app3
   namespace: argocd
+  labels:
+    int128.github.io/e2e-test: fixture
+  finalizers:
+    - resources-finalizer.argocd.argoproj.io
 spec:
   project: default
   source:

pkg/notification/deployment.go

@@ -81,6 +81,9 @@ func generateDeploymentStatus(e Event) *github.DeploymentStatus {
 		case health.HealthStatusDegraded:
 			ds.State = "failure"
 			return &ds
+		case health.HealthStatusMissing:
+			ds.State = "inactive"
+			return &ds
 		}
 	}