Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding mss backup resources #48

Merged
merged 1 commit into from
Jun 27, 2019
Merged

adding mss backup resources #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions image/tools/lib/component/resources.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,10 @@ function component_dump_data {
backup_resource brokeredinfraconfigs ${ns} ${dest}
backup_resource consoleservices ${ns} ${dest}
backup_resource iotconfigs ${ns} ${dest}
backup_resource mobilesecurityservicedbs ${ns} ${dest}
Copy link

@camilamacedo86 camilamacedo86 Jun 26, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think that we should do the backup of the mobilesecurityservices, mobilesecurityservicebackups and mobilesecurityservicedbs because of to restore the MSS Oper and its components the step should be to re-run the installation steps.

Just the APP CRs (mobilesecurityserviceapps) which are not created by MSS Oper should need to be backup. It and the database data are the only things that cannot be recreated by the installation process.

@odra @matskiv

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per SOP PR, only app CRs will be used for restoration:
https://github.com/fheng/integreatly-help/pull/173/files#diff-a516303a301d4ba0827c1cb5b4f16297R331

I think there is nothing wrong with backing up other CRs. You never know when you might need to take a look at them. IMHO, in case of backups more is always better :D

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is because:

  • We/Admin should not use them
  • Why store something that should not be used
  • It can cause confusion
  • It can cause other issues.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We backup all created resources by default, even if those can be created later by installed components (fuse and amq online being examples of it).

Backing a resource up doesn't mean we need to restore all of them but it is usefull to archive those for auditing and backup restoration validation purposes.

Copy link
Contributor Author

@laurafitzgerald laurafitzgerald Jun 26, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the discussion guys. @camilamacedo86 based on the above comments I think we are okay to ahead with the implementation as it is?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I am :-)

backup_resource mobilesecurityserviceapps ${ns} ${dest}
backup_resrouce mobilesecurityservices ${ns} ${dest}
backup_resource mobilesecurityservicebackups ${ns} ${dest}

backup_service_accounts ${ns} ${dest}
backup_role_bindings ${ns} ${dest}
Expand Down