adding mss backup resources #48
Conversation
|
@matskiv thanks for the review. Do I need to do anything to verify it? Also I have included all the resources. I'm probably being over thorough by including the service db and backup crs but I guess there's no harm to back them up in case we ever need them in the future right? They wont all be used by the restore in it's current implementation. |
|
@laurafitzgerald if you want to test it, you need to setup RBAC: https://github.com/integr8ly/backup-container-image/tree/master/templates/openshift/rbac |
| @@ -134,6 +134,10 @@ function component_dump_data { | |||
| backup_resource brokeredinfraconfigs ${ns} ${dest} | |||
| backup_resource consoleservices ${ns} ${dest} | |||
| backup_resource iotconfigs ${ns} ${dest} | |||
| backup_resource mobilesecurityservicedbs ${ns} ${dest} | |||
There was a problem hiding this comment.
I do not think that we should do the backup of the mobilesecurityservices, mobilesecurityservicebackups and mobilesecurityservicedbs because of to restore the MSS Oper and its components the step should be to re-run the installation steps.
Just the APP CRs (mobilesecurityserviceapps) which are not created by MSS Oper should need to be backup. It and the database data are the only things that cannot be recreated by the installation process.
There was a problem hiding this comment.
As per SOP PR, only app CRs will be used for restoration:
https://github.com/fheng/integreatly-help/pull/173/files#diff-a516303a301d4ba0827c1cb5b4f16297R331
I think there is nothing wrong with backing up other CRs. You never know when you might need to take a look at them. IMHO, in case of backups more is always better :D
There was a problem hiding this comment.
It is because:
- We/Admin should not use them
- Why store something that should not be used
- It can cause confusion
- It can cause other issues.
There was a problem hiding this comment.
We backup all created resources by default, even if those can be created later by installed components (fuse and amq online being examples of it).
Backing a resource up doesn't mean we need to restore all of them but it is usefull to archive those for auditing and backup restoration validation purposes.
There was a problem hiding this comment.
Thanks for the discussion guys. @camilamacedo86 based on the above comments I think we are okay to ahead with the implementation as it is?
JIRA
https://issues.jboss.org/browse/INTLY-2573
What
Add backups for the crs belonging to the Mobile Security Service which can be seen here
ping @odra @matskiv @camilamacedo86