Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think that we should do the backup of the mobilesecurityservices, mobilesecurityservicebackups and mobilesecurityservicedbs because of to restore the MSS Oper and its components the step should be to re-run the installation steps.
Just the APP CRs (mobilesecurityserviceapps) which are not created by MSS Oper should need to be backup. It and the database data are the only things that cannot be recreated by the installation process.
@odra @matskiv
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per SOP PR, only app CRs will be used for restoration:
https://github.com/fheng/integreatly-help/pull/173/files#diff-a516303a301d4ba0827c1cb5b4f16297R331
I think there is nothing wrong with backing up other CRs. You never know when you might need to take a look at them. IMHO, in case of backups more is always better :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is because:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We backup all created resources by default, even if those can be created later by installed components (fuse and amq online being examples of it).
Backing a resource up doesn't mean we need to restore all of them but it is usefull to archive those for auditing and backup restoration validation purposes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the discussion guys. @camilamacedo86 based on the above comments I think we are okay to ahead with the implementation as it is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I am :-)