Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support workflow restrictions in github_actions_runner_group #1332

Closed
mike-chen-samsung opened this issue Oct 14, 2022 · 7 comments · Fixed by #1462 or #1513
Closed

Support workflow restrictions in github_actions_runner_group #1332

mike-chen-samsung opened this issue Oct 14, 2022 · 7 comments · Fixed by #1462 or #1513
Labels
Type: Feature New feature or request

Comments

@mike-chen-samsung
Copy link

mike-chen-samsung commented Oct 14, 2022

Support the following options in resource github_actions_runner_group

restricted_to_workflows = boolean
selected_workflows = Array<string>

Affected Resource(s)

  • github_actions_runner_group

References

@kfcampbell
Copy link
Member

This is a valid issue and something we should add! Do you have any interest in opening up a PR to correct this behavior?

@mike-chen-samsung
Copy link
Author

Sure, I can submit a PR over this weekend if someone else doesn't get to it first!

bob-bins pushed a commit to bob-bins/terraform-provider-github that referenced this issue Nov 7, 2022
bob-bins pushed a commit to bob-bins/terraform-provider-github that referenced this issue Nov 7, 2022
bob-bins pushed a commit to bob-bins/terraform-provider-github that referenced this issue Nov 7, 2022
@bob-bins
Copy link
Contributor

bob-bins commented Nov 7, 2022

this issue is dependent on google/go-github#2558

@bob-bins
Copy link
Contributor

the issue above has been completed. just waiting on a new package version now.

@kfcampbell
Copy link
Member

That's awesome, thank you!

@nickfloyd nickfloyd added Type: Feature New feature or request Priority: High and removed Priority: High labels Nov 15, 2022
bob-bins pushed a commit to bob-bins/terraform-provider-github that referenced this issue Nov 20, 2022
bob-bins pushed a commit to bob-bins/terraform-provider-github that referenced this issue Nov 20, 2022
bob-bins pushed a commit to bob-bins/terraform-provider-github that referenced this issue Nov 20, 2022
@nickfloyd nickfloyd moved this to 🏗 In progress in 🧰 Octokit Active Dec 5, 2022
@nickfloyd
Copy link
Contributor

Hey @bob-bins! it looks like you're working on this (from the commits above). Would you mind creating a draft PR so I can follow along and offer suggestions if needed? Please let @kfcampbell or me know if you need any help getting this one over the finish line.

bob-bins pushed a commit to bob-bins/terraform-provider-github that referenced this issue Jan 5, 2023
@bob-bins
Copy link
Contributor

bob-bins commented Jan 5, 2023

@nickfloyd apologies for the wait! Here's a PR: #1462

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in 🧰 Octokit Active Jan 12, 2023
avidspartan1 pushed a commit to avidspartan1/terraform-provider-github that referenced this issue Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
None yet
4 participants