Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow github_actions_runner_group to be created with RestrictedToWorkflows and SelectedWorkflows #1513

Conversation

bob-bins
Copy link
Contributor

@bob-bins bob-bins commented Jan 26, 2023

Resolves #1332


Behavior

Before the change?

After the change?

The user is able to create github_actions_runner_group with restricted_to_workflows and selected_workflows specified.

Other information

  • I am unable to run the tests for this resource because I do not have a personal GitHub Enterprise Account. It would be great if someone with an account could test this PR

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

@kfcampbell
Copy link
Member

I don't have an enterprise account that I can use for this either, unfortunately. I need to figure out how to do that.

Would you be interested in merging as-is?

@bob-bins
Copy link
Contributor Author

bob-bins commented Feb 1, 2023

I would be okay with merging as-is, assuming you or someone else familiar with this part of the codebase did a sanity check, just cause this one updates the input argument reference in the user-facing docs!

@kfcampbell kfcampbell merged commit 2d1b724 into integrations:main Feb 4, 2023
@bob-bins bob-bins deleted the fix-actions-runner-group-workflow-restrictions branch February 5, 2023 00:45
david-heward-unmind added a commit to david-heward-unmind/terraform-provider-github that referenced this pull request Feb 21, 2023
…edToWorkflows and SelectedWorkflows (integrations#1513)"

This reverts commit 2d1b724.
reedloden pushed a commit to reedloden/terraform-provider-github that referenced this pull request Jun 14, 2023
…flows and SelectedWorkflows (integrations#1513)

Co-authored-by: Keegan Campbell <me@kfcampbell.com>
avidspartan1 pushed a commit to avidspartan1/terraform-provider-github that referenced this pull request Feb 5, 2024
…flows and SelectedWorkflows (integrations#1513)

Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support workflow restrictions in github_actions_runner_group
2 participants