Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: support repository autolink references on non-default ports #1551

Closed
1 task done
isometry opened this issue Feb 16, 2023 · 0 comments · Fixed by #1552
Closed
1 task done

[BUG]: support repository autolink references on non-default ports #1551

isometry opened this issue Feb 16, 2023 · 0 comments · Fixed by #1552
Labels
Status: Triage This is being looked at and prioritized Type: Feature New feature or request

Comments

@isometry
Copy link
Contributor

isometry commented Feb 16, 2023 •
edited
Loading

Describe the need

We need to configure repository autolink references with a target running on a non-default HTTPS port. The provider currently validates the target_url_template with a regex that does not allow inclusion of ports within the URL, so this is currently unsupported.

SDK Version

No response

API Version

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@isometry isometry added Status: Triage This is being looked at and prioritized Type: Feature New feature or request labels Feb 16, 2023
@isometry isometry mentioned this issue Feb 16, 2023
Merged
5 tasks
isometry added a commit to isometry/terraform-provider-github that referenced this issue Feb 16, 2023
@isometry
fix: support repository autolink references with non-standard ports
b9829ff 
Resolves integrations#1551
@isometry isometry changed the title [BUG]: support repository autolink references on non-standard ports [BUG]: support repository autolink references on non-default ports Feb 16, 2023
isometry added a commit to isometry/terraform-provider-github that referenced this issue Feb 16, 2023
@isometry
fix: support repository autolink references on non-default ports
dbdbe42 
Resolves integrations#1551
kfcampbell added a commit that referenced this issue Feb 17, 2023
@isometry @kfcampbell
fix: support repository autolink references on non-default ports (#1552)
92449fd 
Resolves #1551

Co-authored-by: Keegan Campbell <me@kfcampbell.com>
@github-project-automation github-project-automation bot moved this from 🆕 Triage to ✅ Done in 🧰 Octokit Active Feb 17, 2023
reedloden pushed a commit to reedloden/terraform-provider-github that referenced this issue Jun 14, 2023
@isometry @kfcampbell @reedloden
fix: support repository autolink references on non-default ports (int…
9522e4d 
…egrations#1552)

Resolves integrations#1551

Co-authored-by: Keegan Campbell <me@kfcampbell.com>
avidspartan1 pushed a commit to avidspartan1/terraform-provider-github that referenced this issue Feb 5, 2024
@isometry @kfcampbell
fix: support repository autolink references on non-default ports (int…
35768d9 
…egrations#1552)

Resolves integrations#1551

Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Triage This is being looked at and prioritized Type: Feature New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@isometry