fix: support repository autolink references with non-default ports #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcanilho
approved these changes
Feb 16, 2023
isometry
force-pushed
the
hotfix/autolink-port
branch
2 times, most recently
from
1fa61cd to
b9829ff
Compare
isometry
force-pushed
the
hotfix/autolink-port
branch
from
b9829ff to
dbdbe42
Compare
kfcampbell
approved these changes
Feb 17, 2023
reedloden
pushed a commit
to reedloden/terraform-provider-github
that referenced
this pull request
Jun 14, 2023
…egrations#1552) Resolves integrations#1551 Co-authored-by: Keegan Campbell <me@kfcampbell.com>
avidspartan1
pushed a commit
to avidspartan1/terraform-provider-github
that referenced
this pull request
Feb 5, 2024
…egrations#1552) Resolves integrations#1551 Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1551
Behavior
Before the change?
target_url_templateincluding non-default port specification is rejectedAfter the change?
target_url_templateincluding non-default port specification is acceptedAdditional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking changelabel)If
Yes, what's the impact:Pull request type
Please add the corresponding label for change this PR introduces:
Type: BugType: FeatureType: DocumentationType: Maintenance