Fix github_team_members: Support github_team_members role edits #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stawik-mesa as the original author, are you willing to check my thinking here and confirm what I am seeing? 🙏 |
|
@csainty I think you are right. Probably I had not enough sleep at the time I implemented it. |
stawik-mesa
approved these changes
Jul 19, 2022
Don't beat yourself up, simple mistake. Now let's tag @jcudit and @kfcampbell as the original approvers and see if they can weigh in. |
|
I've been able to reproduce the failure and subsequent test passing following @csainty's advice locally. I do not believe that the integration tests are being run correctly in CI. I'll get this merged shortly and released soon, and prioritize work on our integration testing setup. |
kazaker
pushed a commit
to auto1-oss/terraform-provider-github
that referenced
this pull request
Dec 28, 2022
Co-authored-by: Keegan Campbell <me@kfcampbell.com>
avidspartan1
pushed a commit
to avidspartan1/terraform-provider-github
that referenced
this pull request
Feb 5, 2024
Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a member's role is changed, only the delete operation is run.
The code clearly sets both
deleteandcreateon lines 140:141, but then usescontinueto loop the iteration after running just one of them.From what I can work out, the test case already checks this and is failing. I have therefore left it unchanged and it should start passing.
I say should because in my local environment I had to edit the test to not mess with org membership, otherwise my collaborator account was pending invitation to the org and failing the test because of that. I am thinking your test setup approves those invitations automatically.
With that change made this PR takes the test from
FAILtoPASSfor me.