Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The create API can also be used to modify the role #1276

Closed

Conversation

csainty
Copy link
Contributor

@csainty csainty commented Sep 6, 2022

Reading the docs further on this action, the create endpoint can also be used for updating role.

If the user is already a member of the team, this endpoint will update the role of the team member's role. To update the membership of a team member, the authenticated user must be an organization owner or a team maintainer.

I made an earlier edit here - #1216 - which works, we're no longer removing access, but the delete/create results in the user being sent two emails informing them they have been removed and added again.

The reason I get caught up on this isn't that I change membership a lot, but when a user gets Org-level Admin rights then the APIs start returning that they are a maintainer of the team, causing terraform to attempt to update them, triggering the emails.
We generally run without human admin accounts, bumping people up and down when needed, so there is noise generated by the code as it exists now.

@github-actions
Copy link

github-actions bot commented Jun 4, 2023

👋 Hey Friends, this pull request has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

@github-actions github-actions bot added the Status: Stale Used by stalebot to clean house label Jun 4, 2023
@github-actions github-actions bot closed this Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Stale Used by stalebot to clean house
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant