Enclave SGX_DEBUG mode not working

[haerdib]

When compiling the worker code in debug mode and starting the worker the following error occurs:

./substratee-worker run
thread 'main' panicked at 'Argument short must be unique

        -s is already in use', /home/ubuntu/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/clap-2.33.3/src/app/parser.rs:193:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

teaclave do not distinguish between debug and non debug mode regarding the cargo build paths. Is there a reason why we do?

Teaclave:

ifeq ($(SGX_DEBUG), 1)
	SGX_COMMON_CFLAGS += -O0 -g
else

We

ifeq ($(SGX_DEBUG), 1)
	SGX_COMMON_CFLAGS += -O0 -g -ggdb
	OUTPUT_PATH := debug
	CARGO_TARGET :=

[clangenb]

Maybe they distinguish between cargo build mode and enclave build mode.

In our case, SGX_DEBUG implies cargo debug mode, which changes the output dir. Maybe this i why teaclave does not do that?

[haerdib]

I've tried the following:

• completely clean & remake
• remove all clap s shortcut commands
• make on a different machine

Nothing worked. I then replaced the cargo output path with release aswell as the build modus set to --release, also in SGX_DEBUG=1, and it worked.

Is there any reason against using the cargo release build mode in SGX_DEBUG mode?

[brenzi]

I don't think we need cargo --debug. SGX_DEBUG should refer to HW mode with debugging enabled (as opposed to HW in production mode

[haerdib]

Then I suggest to use cargo release for both modi, just like teaclave is doing.

[clangenb]

I agree, I think we only lack some debug-symbols when compiling for release, which I believe nobody of us is using at the moment.

Furthermore, release yields significantly smaller binaries.

[brenzi]

so what's the action to be taken now?

[clangenb]

I think closing this issue as won't fix.

[clangenb]

I have just seen that I actually gave the wrong advice. I think we should just cargo --release in any case

[haerdib]

I think we need to update our makefile anyway to solve issue #373 and https://github.com/integritee-network/deployment/issues/6. As this process will include quite some adaptions to match the makefile of teaclave, this issue could easily be solved along the way.