Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build for SGX_DEBUG=1 #419

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Fix build for SGX_DEBUG=1 #419

merged 1 commit into from
Sep 23, 2021

Conversation

murerfel
Copy link
Contributor

@murerfel murerfel commented Sep 23, 2021

Use cargo --release also in case of SGX_DEBUG=1 and hence also the corresponding target/release folder.

This still might not be the best debugging experience - but that would be a lot tougher to achieve (if not impossible), considering the nature of the enclave (which cannot be debugged by design).

Closes #375

@murerfel murerfel self-assigned this Sep 23, 2021
Copy link
Contributor

@haerdib haerdib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. Thanks!

Use cargo --release also in case of SGX_DEBUG=1 and hence also the corresponding target/release folder. Closes #375
@clangenb
Copy link
Contributor

It might not be optimal, but until now, we never made use of the debugger anyhow.

However, for your information, the enclave can be debugged if SGX_DEBUG=1, we just never made a setup accordingly because it is even harder to set up with remote development, which CLion does currently not support (at least in rust.)

Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGBQT!

@murerfel
Copy link
Contributor Author

It might not be optimal, but until now, we never made use of the debugger anyhow.

However, for your information, the enclave can be debugged if SGX_DEBUG=1, we just never made a setup accordingly because it is even harder to set up with remote development, which CLion does currently not support (at least in rust.)

Ah good to know! 🚀 It would certainly be nice in the future to have debug capabilities

@murerfel murerfel merged commit 564c137 into master Sep 23, 2021
@clangenb clangenb deleted the bugfix/fm-sgx-debug-mode-375 branch September 24, 2021 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enclave SGX_DEBUG mode not working
3 participants