Skip to content
This repository has been archived by the owner on Jan 7, 2023. It is now read-only.

[Do Not Merge] Don't expose VK_EXT_descriptor_indexing on APL #135

Closed
wants to merge 1 commit into from

Conversation

renchenglei
Copy link
Contributor

No description provided.

@renchenglei
Copy link
Contributor Author

@tpalli & @strassek, this change is for issue #128. it seems that we still have "timeout" issue with latest upstream mesa, could we not expose VK_EXT_descriptor_indexing on low performance platform?

@@ -123,7 +123,7 @@ def __init__(self, version, enable):
Extension('VK_EXT_debug_report', 8, True),
Extension('VK_EXT_depth_clip_enable', 1, True),
Extension('VK_EXT_descriptor_indexing', 2,
'device->has_a64_buffer_access && device->has_bindless_images'),
'device->has_a64_buffer_access && device->has_bindless_images && !ANDROID'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will disable it from all devices, not just APL. I think you could make something like this: !(ANDROID && device->info.is_broxton) so that it would be only for APL.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, will double check if issue is also reproduced on KBL. And then enhance the change here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having said that, I don't think this is a good approach in longer term. Google CDD for Android 10 strongly recommends Vulkan 1.1 support and I would not be surprised that they want to use any available extensions too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, a good news is that upstream mesa has optimization for timeout issue. Some timeout issue has gone with latest code. Will keep monitor the latest code, if this issue also could be fixed with later mesa changes, we will cherry pick fix to our github.

@renchenglei renchenglei closed this Feb 4, 2020
@renchenglei renchenglei deleted the binding_model branch February 4, 2020 07:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants