Skip to content
This repository has been archived by the owner on Jan 7, 2023. It is now read-only.

[Do Not Merge] Don't expose VK_EXT_descriptor_indexing on APL #135

Closed
wants to merge 1 commit into from
+1 −1
Closed

[Do Not Merge] Don't expose VK_EXT_descriptor_indexing on APL #135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/intel/vulkan/anv_extensions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def __init__(self, version, enable):
Extension('VK_EXT_debug_report', 8, True),
Extension('VK_EXT_depth_clip_enable', 1, True),
Extension('VK_EXT_descriptor_indexing', 2,
'device->has_a64_buffer_access && device->has_bindless_images'),
'device->has_a64_buffer_access && device->has_bindless_images && !ANDROID'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will disable it from all devices, not just APL. I think you could make something like this: !(ANDROID && device->info.is_broxton) so that it would be only for APL.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, will double check if issue is also reproduced on KBL. And then enhance the change here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having said that, I don't think this is a good approach in longer term. Google CDD for Android 10 strongly recommends Vulkan 1.1 support and I would not be surprised that they want to use any available extensions too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, a good news is that upstream mesa has optimization for timeout issue. Some timeout issue has gone with latest code. Will keep monitor the latest code, if this issue also could be fixed with later mesa changes, we will cherry pick fix to our github.

Extension('VK_EXT_direct_mode_display', 1, 'VK_USE_PLATFORM_DISPLAY_KHR'),
Extension('VK_EXT_display_control', 1, 'VK_USE_PLATFORM_DISPLAY_KHR'),
Extension('VK_EXT_display_surface_counter', 1, 'VK_USE_PLATFORM_DISPLAY_KHR'),
Expand Down