Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UR][L0] Upgrade L0 loader to v1.15.1 #11844

Merged
merged 9 commits into from
Dec 15, 2023
Merged

[UR][L0] Upgrade L0 loader to v1.15.1 #11844

merged 9 commits into from
Dec 15, 2023

Conversation

jandres742
Copy link
Contributor

This to use latest features present in L0 spec.

@jandres742 jandres742 mentioned this pull request Nov 9, 2023
Merged
@jandres742 jandres742 force-pushed the updateL0loader branch 2 times, most recently from 885f972 to 6ad721b Compare November 9, 2023 22:05
@jandres742
Copy link
Contributor Author

@smaslov-intel : I need this for several new features in L0 spec. is it ok to upgrade the L0 loader here in the intel/llvm? I'm upgrading it in the UR L0 adapter here oneapi-src/unified-runtime#1061

@smaslov-intel
Copy link
Contributor

@smaslov-intel : I need this for several new features in L0 spec. is it ok to upgrade the L0 loader here in the intel/llvm? I'm upgrading it in the UR L0 adapter here oneapi-src/unified-runtime#1061

I think we should then also update the L0 loader that is used in CI testing.

@jandres742
Copy link
Contributor Author

@smaslov-intel : I need this for several new features in L0 spec. is it ok to upgrade the L0 loader here in the intel/llvm? I'm upgrading it in the UR L0 adapter here oneapi-src/unified-runtime#1061

I think we should then also update the L0 loader that is used in CI testing.

thanks @smaslov-intel . How can we do that? is it something I can add as part of this PR or does it need to be done by someone else?

@smaslov-intel
Copy link
Contributor

@smaslov-intel : I need this for several new features in L0 spec. is it ok to upgrade the L0 loader here in the intel/llvm? I'm upgrading it in the UR L0 adapter here oneapi-src/unified-runtime#1061

I think we should then also update the L0 loader that is used in CI testing.

thanks @smaslov-intel . How can we do that? is it something I can add as part of this PR or does it need to be done by someone else?

@bader : could you help answering this?
Perhaps, it is somehow pre-built into a package loaded for testing: https://github.com/intel/llvm/blob/156b730a6886b1394b7b91e2455d6e6b42ac6ec1/.github/workflows/sycl_linux_precommit.yml#L84C20-L84C63

@bader
Copy link
Contributor

bader commented Nov 15, 2023

@aelovikov-intel, could you suggest the way to test L0 loader update?

@aelovikov-intel
Copy link
Contributor

Sorry, I don't know how the closing happened...

@aelovikov-intel
Copy link
Contributor

Why can't we get that update as part of the GPU driver? We don't want to run our testing with pre-release GPU stack...

@smaslov-intel
Copy link
Contributor

e don't want to run our testing with pre-release GPU stac

It looks we need all the right components spelled (in sync with each other) in https://github.com/intel/llvm/blob/sycl/devops/dependencies.json

@jandres742
Copy link
Contributor Author

jandres742 commented Nov 15, 2023 •
edited by bader
Loading

Why can't we get that update as part of the GPU driver? We don't want to run our testing with pre-release GPU stack...

thanks @aelovikov-intel, Definitely, we can update the loader as part of the GPU driver. How can we do that? What is the next GPU driver to be upgraded, and when is it planned?

@jandres742 jandres742 force-pushed the updateL0loader branch 3 times, most recently from f23d4ba to 2103cfa Compare November 22, 2023 21:12
Jaime Arteaga and others added 4 commits November 22, 2023 13:17
[UR][L0] Add UR_L0_LEAKS_DEBUG key
151b9fe 
Use a new environment variable, UR_L0_LEAKS_DEBUG, to check for leaks in
the UR L0 adapter, instead of relying on a specific value being set in
UR_L0_DEBUG.

Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
@kbenzie
[UR] Bump tag to 31b654f981f6098936e7f04c65803395a2ea343a
c779e41
@kbenzie
[Graph] Update more tests to use UR_L0_LEAKS_DEBUG
6d74ec7
[UR][L0] Upgrade L0 loader to v1.15.1
2103cfa 
This to use latest features present in L0 spec.

Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
@kbenzie kbenzie marked this pull request as ready for review December 14, 2023 17:56
@kbenzie kbenzie requested review from a team as code owners December 14, 2023 17:56
EwanC
EwanC approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cosmetic modification to graphs tests

@kbenzie
Copy link
Contributor

kbenzie commented Dec 15, 2023

@intel/llvm-gatekeepers please merge.

@steffenlarsen steffenlarsen merged commit 31d5579 into intel:sycl Dec 15, 2023
11 checks passed
@kbenzie kbenzie mentioned this pull request Dec 15, 2023
Closed
17 tasks
callumfare pushed a commit to kbenzie/llvm that referenced this pull request Dec 18, 2023
@kbenzie @callumfare
[UR][L0] Upgrade L0 loader to v1.15.1 (intel#11844)
63b8693 
This to use latest features present in L0 spec.

---------

Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbenzie kbenzie kbenzie approved these changes

@EwanC EwanC EwanC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jandres742 @smaslov-intel @bader @aelovikov-intel @kbenzie @EwanC @steffenlarsen