Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified Runtime v0.8.2 changes combine #12192

Closed
wants to merge 18 commits into from

Conversation

@kbenzie kbenzie changed the title Unified Runtime v0.8.x changes combine Unified Runtime v0.8.2 changes combine Dec 15, 2023
aarongreig and others added 18 commits December 18, 2023 08:57
Pulls in the following fixes to the CUDA and HIP adapters:

* [HIP] Correctly set HIP Kernel Buffer Arguments 
* [HIP] Fix host/device synchronization 
* [HIP][CTS] Fix Device CTS failures 
* [HIP] Fix get mem size segfault 
* [HIP] Implement urMemImageGetInfo
* [HIP] Define all UR entry points
* [CUDA] Add support for binary type query
* [CUDA] Update hint functions to only return warnings instead of errors
Includes UR changes from [ [OpenCL] Fix memory leak and coverity issue
with struct-to-array casts intel#1048
](oneapi-src/unified-runtime#1048).
…ompile (intel#11464)

piProgramBuild receives a list of devices, while urProgramBuild does
not. This produces a series of issues when a UR program needs to be
created for a specific device.

So define a new API, called urProgramBuildExp to pass this list.

Requires related patch in Unified Runtime Adapters here:
oneapi-src/unified-runtime#934

---------

Signed-off-by: Spruit, Neil R <neil.r.spruit@intel.com>
Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
In oneapi-src/unified-runtime#993 the type of
the `UR_OPENCL_ICD_LOADER_LIBRARY` CMake variable will change to a cache
variable, as such the usage of this variable also needs to up updated.
Use a new environment variable, UR_L0_LEAKS_DEBUG, to check for leaks in
the UR L0 adapter, instead of relying on a specific value being set in
UR_L0_DEBUG.

---------

Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
intel-llvm CI run for adding Command Buffers to the OpenCL Adapter in
Unified Runtime - oneapi-src/unified-runtime#966

Also completes follow-on work identified in intel#11599 to add an OpenCL
section to the SYCL-Graphs docs and update the e2e Graph tests. Updating
the tests has since been completed in a separate PR -
intel#11877

Depends on intel#11820 merging first.

---------

Co-authored-by: Pablo Reble <pablo@reble.org>
Co-authored-by: Ewan Crawford <ewan@codeplay.com>
Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
Run CI for oneapi-src/unified-runtime#936

Depends on intel#11718 merging first.

---------

Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
…ntel#11541)

When event list is null, a barrier is still needed for all previous
commands, so fix it.

---------

Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
…cs. (intel#12005)

Also handle translating these properties in pi2ur.

oneapi-src/unified-runtime#1123

---------

Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
Corresponding UR changes
oneapi-src/unified-runtime#1179

---------

Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
Corresponding UR chanages
oneapi-src/unified-runtime#1105.

---------

Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
This to use latest features present in L0 spec.

---------

Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
@callumfare callumfare changed the base branch from sycl to sycl-rel-5_1_0 December 18, 2023 09:01
@callumfare callumfare marked this pull request as ready for review December 19, 2023 11:12
@callumfare callumfare requested review from a team as code owners December 19, 2023 11:12
@kbenzie kbenzie mentioned this pull request Jan 5, 2024
7 tasks
@againull againull removed their request for review February 8, 2024 21:20
@kbenzie kbenzie closed this Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants