[SYCL] Sort platforms in platform::get_platforms() #12719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that the first one would contain the most preferrable device in case SYCL applications/library performs manual device selection and defaults to the first available device.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
This was referenced Feb 21, 2024
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Feb 23, 2024
Started to fail in post commit after intel#12719. This looks like a pre-existing bug in the test so I'm going to temporarily disable the test instead of reverting. Will work on the fix with highest priority after that.
steffenlarsen
pushed a commit
that referenced
this pull request
Feb 23, 2024
Started to fail in post commit after #12719. This looks like a pre-existing bug in the test so I'm going to temporarily disable the test instead of reverting. Will work on the fix with highest priority after that.
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Feb 26, 2024
…ntel#12719)" This commit reverts the functional change because device filtering accesses plugins directly and not through the get_platforms() interface resulting in inconsistent device numbering. Test bug-fixes from the PR are not being reverted though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that the first one would contain the most preferrable device in case SYCL applications/library performs manual device selection and defaults to the first available device.