[SYCL][NFC] Fix dependencies for SYCLLowerIR #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrea Bocci <andrea.bocci@cern.ch>
|
Fixes #1320. |
fwyzard
changed the title
bader
approved these changes
Mar 15, 2020
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Mar 17, 2020
…e_api_test * origin/sycl: (1188 commits) [SYCL][CUDA] Improve CUDA backend documentation (intel#1293) [SYCL] Emit textual IR when -S -fsycl-device-only is used (intel#1314) [SYCL] Add prototype of group algorithms (intel#1236) [SYCL] XFAIL test on windows to unblock pulldown Allow Intel Loop Controls only with SPV_INTEL_fpga_loop_controls Apply suggested assert msg change Implement SPV_INTEL_io_pipes extension [SYCL] Fix dependencies for SYCLLowerIR (intel#1321) [CI] Allow builds without pre-downloaded OpenCL in configure.py (intel#1317) [SYCL] Move SYCL headers from standard clang location (intel#1308) [mlir] Add support for generating dialect declarations via tablegen. Be more strict when checking existence of foo [CodeGenPrepare] Freeze condition when transforming select to br [ORC] Remove an undefined static method from LLJIT. [JITLink][AArch64] Fix incorrect capitalization in a testcase name. [ORC] Print symbol flags and materializer name in ExecutionSession::dump. [JITLink][MachO] Re-apply b64afad, MachO linker-private support, with fixes. Basic Block Sections Support. Test commit. [SYCL][Doc] Deploy documentation for PI (intel#1318) ...
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Feb 23, 2023
intel#1321) I had a bit of trouble working out why lit was failing to start after configuration had succceeded. Turns out I was passing a partial tuple to cmake `-DCHECK_SYCL_ALL` due to a typo in a shell variable. This patch verifies that both parts of each tuple in the `CHECK_SYCL_ALL` variable are nonempty and terminates configuration with an error message otherwise, which should make it a bit more obvious what's happening.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark SYCLLowerIR as a library and add explicit dependencies of SYCLLowerIR on other LLVM libraries; and of clang on SYCLLowerIR.