Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][L0] Make all L0 events have device-visibility #4534

Merged
merged 6 commits into from
Sep 17, 2021

Conversation

smaslov-intel
Copy link
Contributor

@smaslov-intel smaslov-intel commented Sep 10, 2021

Make all L0 events have device-visibility by default, and only create/signal/query their host-visible proxy event on demand.
Since this is not showing better performance yet and requires further tuning, I am going to disable it by default initially.
Test is coming in intel/llvm-test-suite#456

Signed-off-by: Sergey V Maslov sergey.v.maslov@intel.com

…only create/signal/query their host-visible proxy event on demand.

Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
@smaslov-intel
Copy link
Contributor Author

/summary:run

Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
Copy link
Contributor

@asudarsa asudarsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a nitpick. Looks good to me..

Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd like @pvchupin to approve.

Copy link
Contributor

@pvchupin pvchupin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to me. Please see comment from @asudarsa.

sycl/doc/EnvironmentVariables.md Show resolved Hide resolved
@bader bader merged commit d66cc4b into intel:sycl Sep 17, 2021
alexbatashev added a commit to alexbatashev/llvm that referenced this pull request Sep 18, 2021
* upstream/sycl: (36 commits)
  [SYCL] Add SYCL2020 target::device enumeration value (intel#4587)
  [SYCL][Doc] Update ITT instrumentation docs (intel#4503)
  [SYCL][L0] Make all L0 events have device-visibility (intel#4534)
  [SYCL] Updated Level-Zero backend spec according to SYCL 2020 standard (intel#4560)
  [SYCL] Add error_code support for SYCL 1.2.1 exception classes (intel#4574)
  [SYCL][CI] Provide --ci-defaults option for config script (intel#4583)
  [CI] Switch GitHub Actions to Ubuntu 20.04 (intel#4582)
  [SYCL][CUDA] Fix context clearing in PiCuda tests (intel#4483)
  [SYCL] Hide SYCL service kernels (intel#4519)
  [SYCL][L0] Fix mismatched ZE call count (intel#4559)
  [SYCL] Remove function pointers extension (intel#4459)
  [GitHub Actions] Uplift clang version in post-commit validation (intel#4581)
  [SYCL] Ignore usm prefetch dummy flag (intel#4568)
  [SYCL][Group algorithms] Add group sorting algorithms implementation (intel#4439)
  [SYCL] Resolve name clash with a user defined symbol (intel#4570)
  [clang-offload-wrapper] Do not create .tgtimg section with -emit-reg-funcs=0 (intel#4577)
  [SYCL][FPGA] Remove deprecated attribute functionality (intel#4532)
  [SYCL] Remove _class aliases (intel#4465)
  [SYCL][CUDA][HIP] Report every device in its own platform (intel#4571)
  [SYCL][L0] make_device shouldn't need platform as an input (intel#4561)
  ...
@smaslov-intel smaslov-intel deleted the deviceonly branch September 21, 2021 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants