[SYCL] Ignore usm prefetch dummy flag #4568
Conversation
|
Instead of changing the migration flags to 0, it would be better to adopt the assertion this PR removes from level_zero. |
|
I think it makes more sense to pass 0. As it expresses that there is no flag, so no action is needed. |
Fair point. Then PI CUDA and PI HIP can just keep their asserts. |
Would it not make sense to move all PI's over to one sort of assert? As all ignore the flag in the same way. |
I mostly intended to make it clear that there should be some sort of check at least, where the easiest option would be to simply restore the events. |
|
Ahh okay, sorry I misunderstood. Thank you for clarifying. |
No worries. I could have been clearer to begin with. 😄 |
sycl/plugins/cuda/pi_cuda.cpp
Outdated
| @@ -4589,22 +4589,22 @@ pi_result cuda_piextUSMEnqueueMemcpy(pi_queue queue, pi_bool blocking, | |||
| return result; | |||
| } | |||
|
|
|||
| // flags is currently ignored as it is a placeholder for future features | |||
There was a problem hiding this comment.
Very minor, but it is not "ignored" anymore, so maybe the comment should be inside the function and be adapted to reflect the new behavior for unrecognized flags.
sycl/plugins/cuda/pi_cuda.cpp
Outdated
| pi_result cuda_piextUSMEnqueuePrefetch(pi_queue queue, const void *ptr, | ||
| size_t size, | ||
| pi_usm_migration_flags flags, | ||
| pi_uint32 num_events_in_waitlist, | ||
| const pi_event *events_waitlist, | ||
| pi_event *event) { | ||
|
|
||
| if (!(flags & ~PI_USM_MIGRATION_TBD0)) |
There was a problem hiding this comment.
Since we now expect flags to be 0, the condition here and in the other backends should be flags != 0. Note that level-zero negates the condition, since it is an assert, so its condition should be flags == 0 instead.
|
Does |
Yes |
|
@AidanBeltonS , please also add comment to the definition of |
@AidanBeltonS, eagerly looking forward for this to fix llvm-test-suite. |
|
llvm-test-suite PR has been created |
* upstream/sycl: (36 commits) [SYCL] Add SYCL2020 target::device enumeration value (intel#4587) [SYCL][Doc] Update ITT instrumentation docs (intel#4503) [SYCL][L0] Make all L0 events have device-visibility (intel#4534) [SYCL] Updated Level-Zero backend spec according to SYCL 2020 standard (intel#4560) [SYCL] Add error_code support for SYCL 1.2.1 exception classes (intel#4574) [SYCL][CI] Provide --ci-defaults option for config script (intel#4583) [CI] Switch GitHub Actions to Ubuntu 20.04 (intel#4582) [SYCL][CUDA] Fix context clearing in PiCuda tests (intel#4483) [SYCL] Hide SYCL service kernels (intel#4519) [SYCL][L0] Fix mismatched ZE call count (intel#4559) [SYCL] Remove function pointers extension (intel#4459) [GitHub Actions] Uplift clang version in post-commit validation (intel#4581) [SYCL] Ignore usm prefetch dummy flag (intel#4568) [SYCL][Group algorithms] Add group sorting algorithms implementation (intel#4439) [SYCL] Resolve name clash with a user defined symbol (intel#4570) [clang-offload-wrapper] Do not create .tgtimg section with -emit-reg-funcs=0 (intel#4577) [SYCL][FPGA] Remove deprecated attribute functionality (intel#4532) [SYCL] Remove _class aliases (intel#4465) [SYCL][CUDA][HIP] Report every device in its own platform (intel#4571) [SYCL][L0] make_device shouldn't need platform as an input (intel#4561) ...
Patch removes assertions in pi_cuda, pi_hip, and pi_level_zero which fail based upon the flag given to the function.
prefetch_usmfunction now does not pass flag to PI.The flag is a placeholder and should be ignored.
This is a follow up PR from issue #4467