-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async Reset Improvements #533
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
There were a handful of bugs and issues related to asynchronous reset, reset values, simulator injections, waveform dumping, etc. This PR addresses a variety of those issues.
InvalidReservedNameException
messagesasyncReset
toSequential
,FiniteStateMachine
,Pipeline
,FlipFlop
,flop
x
if a trigger and non-trigger happen at the "same time" in a tick to help catch non-synthesizable behavior in designs around flopsresetValues
behavior forPipeline
sPipeline
to useSequential
's automation instead of its ownSimulator
so that it executes injected actions within main tick if possible.It also encompasses and supersedes #483
Related Issue(s)
Fix #531
Fix #528
Fix #338
Supersedes #483
Testing
Added extensive testing for applicable areas
Backwards-compatibility
Yes!
Simulator
can now occur in either themainTick
orclkStable
phases. This API will generally continue to work as expected and as it always has, but in some scenarios could slightly change the behavior of existing testbenches.Simulator.run
now yields execution of the Dart event loop prior to beginning the simulation. This makes actions taken before starting the simulation more predictable, but may slightly change behavior in existing testbenches that relied on a potential delay.Documentation
Generally no, but API docs were updated. This is mostly fixing behavior, not adding/changing.