Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make settlement-engine to take environmental values #194

Closed
dora-gt opened this issue Aug 7, 2019 · 4 comments
Closed

Make settlement-engine to take environmental values #194

dora-gt opened this issue Aug 7, 2019 · 4 comments
Assignees
@dora-gt
Labels
enhancement
Milestone
Milestone 2

Comments

@dora-gt
Copy link
Collaborator

dora-gt commented Aug 7, 2019 •
edited
Loading

While node takes environmental values, ethereum-ledger does not.
It might be better to take environmental values to have consistency.
@dora-gt
Copy link
Collaborator Author

dora-gt commented Aug 12, 2019

If @gakonst doesn't mind, I'd like to fix this just for my Rust study.

@gakonst
Copy link
Member

gakonst commented Aug 13, 2019

Sure.

@emschwartz emschwartz added this to the Next Milestone milestone Aug 15, 2019
@gakonst gakonst assigned dora-gt and unassigned gakonst Aug 15, 2019
@dora-gt
Copy link
Collaborator Author

dora-gt commented Aug 16, 2019

It seems that this issue is related to #169, #171, #206. These should probably be solved at the same time.

@dora-gt dora-gt mentioned this issue Aug 20, 2019
Closed
1 task
dora-gt added a commit to dora-gt/interledger-rs that referenced this issue Aug 23, 2019
@dora-gt
feat(eth-se): fixed ethereum settlement engine to take environment va…
4599019 
…riables

Signed-off-by: Taiga Nakayama <dora@dora-gt.jp>

interledger#194
@dora-gt dora-gt mentioned this issue Aug 23, 2019
Closed
dora-gt added a commit to dora-gt/interledger-rs that referenced this issue Aug 28, 2019
@dora-gt
feat(main.rs, etc): fixed not to use struct opt, etc
40778d4 
Signed-off-by: Taiga Nakayama <dora@dora-gt.jp>

interledger#113, interledger#206, interledger#171, interledger#194
dora-gt added a commit to dora-gt/interledger-rs that referenced this issue Aug 29, 2019
@dora-gt
feat(main.rs etc.): cli improvement
b408c51 
Every command accepts arguments, config file settings, env vars. `interledger` and
`interledger-settlement-engines` are almost consistent.

Signed-off-by: Taiga Nakayama <dora@dora-gt.jp>

interledger#171, interledger#113, interledger#206, interledger#194, interledger#215
@dora-gt dora-gt mentioned this issue Aug 29, 2019
Closed
15 tasks
dora-gt added a commit to dora-gt/interledger-rs that referenced this issue Sep 8, 2019
@dora-gt
feat(cli, documents): command line interface improvement
a48d729 
Every command accepts arguments, config file settings, env vars. `interledger` and
`interledger-settlement-engines` are almost consistent.

BREAKING CHANGE: Some arguments are now obsolete. On interledger package: server_secret ->
secret_seed, btp_server -> btp_server_url, http_server -> http_server_url, redis_connection ->
redis_url, http_address -> http_bind_address, settlement_address -> settlement_api_bind_address,
btp_address -> btp_bind_address, btp_uri -> btp_server_url, http_url -> http_server_url. On
interledger-settlement-engines package: http_address -> settlement_api_bind_address,
ethereum_endpoint -> ethereum_url, redis_uri -> redis_url.

Signed-off-by: Taiga Nakayama <dora@dora-gt.jp>

interledger#171, interledger#113, interledger#206, interledger#194, interledger#215
@emschwartz
Copy link
Member

Closed by #290

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dora-gt dora-gt

Labels
enhancement
Projects
None yet
Milestone
Milestone 2
Development

No branches or pull requests
3 participants
@dora-gt @emschwartz @gakonst