-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make settlement-engine to take environmental values #194
Comments
If @gakonst doesn't mind, I'd like to fix this just for my Rust study. |
Sure. |
1 task
dora-gt
added a commit
to dora-gt/interledger-rs
that referenced
this issue
Aug 23, 2019
…riables Signed-off-by: Taiga Nakayama <dora@dora-gt.jp> interledger#194
Closed
dora-gt
added a commit
to dora-gt/interledger-rs
that referenced
this issue
Aug 28, 2019
Signed-off-by: Taiga Nakayama <dora@dora-gt.jp> interledger#113, interledger#206, interledger#171, interledger#194
dora-gt
added a commit
to dora-gt/interledger-rs
that referenced
this issue
Aug 29, 2019
Every command accepts arguments, config file settings, env vars. `interledger` and `interledger-settlement-engines` are almost consistent. Signed-off-by: Taiga Nakayama <dora@dora-gt.jp> interledger#171, interledger#113, interledger#206, interledger#194, interledger#215
dora-gt
added a commit
to dora-gt/interledger-rs
that referenced
this issue
Sep 8, 2019
Every command accepts arguments, config file settings, env vars. `interledger` and `interledger-settlement-engines` are almost consistent. BREAKING CHANGE: Some arguments are now obsolete. On interledger package: server_secret -> secret_seed, btp_server -> btp_server_url, http_server -> http_server_url, redis_connection -> redis_url, http_address -> http_bind_address, settlement_address -> settlement_api_bind_address, btp_address -> btp_bind_address, btp_uri -> btp_server_url, http_url -> http_server_url. On interledger-settlement-engines package: http_address -> settlement_api_bind_address, ethereum_endpoint -> ethereum_url, redis_uri -> redis_url. Signed-off-by: Taiga Nakayama <dora@dora-gt.jp> interledger#171, interledger#113, interledger#206, interledger#194, interledger#215
Closed by #290 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While
node
takes environmental values,ethereum-ledger
does not.It might be better to take environmental values to have consistency.
The text was updated successfully, but these errors were encountered: