-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #546 #551
Fixes #546 #551
Conversation
Co-Authored-By: Kincaid O'Neil <kincaidoneil@users.noreply.github.com>
Signed-off-by: sappenin <sappenin@gmail.com>
Signed-off-by: sappenin <sappenin@gmail.com>
…stream-connection-details
Signed-off-by: sappenin <sappenin@gmail.com>
Signed-off-by: sappenin <sappenin@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should make any changes to the spec until we've implemented said changes and have some use case that requires this to be done the same way in all implementations. This frame is already part of the protocol so we can use it for now. In the future we may choose to deprecate it or make it mandatory but I don't think we have enough information to make that determination now.
Signed-off-by: sappenin <sappenin@gmail.com>
Sounds fine to me. I have removed any breaking changes from this PR - the only thing left is non-breaking clarifications to the spec. In the Java STREAM implementation, we're going to support what JS is doing (and apparently what Rust is going to do). We might experiment with what was proposed earlier in this PR (i.e., respond to a As a community, we can revisit the desired behavior here sometime in the future if we ever decide this is worth changing (see #554, which is just a tracking issue, if you're interested). |
Signed-off-by: sappenin <sappenin@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment which is unrelated to this change but could be added in as another quick fix
Signed-off-by: sappenin <sappenin@gmail.com>
@adrianhopebailie The build doesn't seem to be working for whatever reason. Once you determine what the problem is, let me know and I can push another change. |
@mDuo13 @ryangyoung any idea what could be happening here. Could this be related to the change of template? |
Signed-off-by: sappenin <sappenin@gmail.com>
Signed-off-by: sappenin <sappenin@gmail.com>
Signed-off-by: sappenin <sappenin@gmail.com>
Skip Version Check Signed-off-by: sappenin <sappenin@gmail.com>
Fixes #546 by clarifying the STREAM RFC.
ConnectionAssetDetails
MUST not change during the lifetime of a Connection.Signed-off-by: sappenin sappenin@gmail.com