Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #546 #551

Merged
merged 14 commits into from
Oct 23, 2019
Merged

Fixes #546 #551

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
81ef118
Fixes #546
sappenin Oct 8, 2019
32be872
Update 0029-stream/0029-stream.md
sappenin Oct 8, 2019
4511557
Update per PR comments.
sappenin Oct 8, 2019
5c87622
Remove redundant clarification.
sappenin Oct 8, 2019
575cab2
Merge branch 'master' of github.com:interledger/rfcs into df/clarify-…
sappenin Oct 9, 2019
fcb0dcb
Remove wordy sentence
sappenin Oct 9, 2019
c61fb33
Remove language about ignoring subsequent frames.
sappenin Oct 9, 2019
a1b9ea8
Removing breaking proposed changes.
sappenin Oct 9, 2019
24aeec6
Remove whitespace
sappenin Oct 9, 2019
eb5cc17
Remove inaccurate example.
sappenin Oct 16, 2019
6d4af7c
Bumping draft number to test the build scripts
sappenin Oct 23, 2019
b6fa521
Reducing the draft num
sappenin Oct 23, 2019
cdb0085
Restoring correct draft number
sappenin Oct 23, 2019
f1e4dc2
Skip Version Check
sappenin Oct 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions 0029-stream/0029-stream.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
title: STREAM - A Multiplexed Money and Data Transport for ILP
draft: 7
draft: 8
---

# STREAM: A Multiplexed Money and Data Transport for ILP
Expand Down Expand Up @@ -174,7 +174,11 @@ Implementations SHOULD wait for a valid response (encrypted with the same shared

#### 4.3.1. Connection Asset Details

Each endpoint MAY expose their asset details by sending a `ConnectionAssetDetails` frame.
Each endpoint MAY expose their asset details by sending a `ConnectionAssetDetails` frame. This frame is optional because some use-cases, such as Web Monetization, do not require it.
sappenin marked this conversation as resolved.
Show resolved Hide resolved

Asset details exposed by this frame MUST not change during the lifetime of a Connection. Because of this, endpoints that honor `ConnectionAssetDetails` frames SHOULD ignore any repeat `ConnectionAssetDetails` frames for a given Connection.

Endpoints that wish to discover the other endpoint's asset details MAY send a `ConnectionNewAddress` frame to prompt the endpoint to respond with a `ConnectionAssetDetails` frame.
sappenin marked this conversation as resolved.
Show resolved Hide resolved

### 4.4. Streams

Expand Down Expand Up @@ -327,6 +331,8 @@ If implementations allow half-open connections, an endpoint MAY continue sending
|---|---|---|
| Source Address | ILP Address | New ILP address of the endpoint that sent the frame. |

If an endpoint receives a `ConnectionNewAddress` frame, the endpoint MUST respond with a `ConnectionAssetDetails` frame.

#### 5.3.3. `ConnectionMaxData` Frame

| Field | Type | Description |
Expand Down Expand Up @@ -432,6 +438,8 @@ In other words, if a sender resends data (e.g. because a packet was lost), it MU
| Source Asset Code | Utf8String | Asset code of endpoint that sent the frame. |
| Source Asset Scale | UInt8 | Asset scale of endpoint that sent the frame. |

Asset details exposed by this frame MUST not change during the lifetime of a Connection. Because of this, endpoints that honor `ConnectionAssetDetails` frames SHOULD ignore any repeat `ConnectionAssetDetails` frames for a given Connection.
sappenin marked this conversation as resolved.
Show resolved Hide resolved

### 5.4. Error Codes

Error codes are sent in `StreamClose` and `ConnectionClose` frames to indicate what caused the stream or connection to be closed.
Expand Down