Update @jsonapi to use functools.wraps #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In internetarchive/openlibrary#5910 we want to use Python's `inspect` module to access the method.__code__ and method.__doc__ variables but @decorators block such access unless https://docs.python.org/3/library/functools.html#functools.wraps is used.
This was referenced Nov 29, 2021
mekarpeles
approved these changes
Dec 2, 2021
There was a problem hiding this comment.
lgtm, discussed w/ @cclauss on 1:1 call; we should add a label that this requires special deploy (i.e. only deploying this PR w/ latest version of infogami)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a more complete solution to 12f6c18
In internetarchive/openlibrary#5910 we want to use Python's
inspectmodule to access themethod.__code__andmethod.__doc__variables but @decorators block such access unless we use https://docs.python.org/3/library/functools.html#functools.wraps