Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resync infogami #5952

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Dec 8, 2021

Caution on the simplejson to json changes in internetarchive/infogami@d8777b9

Infogami has gotten out of date and we need the changes around @jsonapi for reflection.

Technical

Testing

Screenshot

Stakeholders

@mekarpeles
Copy link
Member

potential gotcha: switching to json instead of simplejson

@mekarpeles mekarpeles removed their assignment Dec 13, 2021
@mekarpeles mekarpeles added the Priority: 1 Do this week, receiving emails, time sensitive, . [managed] label Dec 13, 2021
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not testing this one 😬 The only risk is the simplejson changes ; we might see a spike in sentry errors if that is causing issues. We can rollback if it does cause issues ; testing this would be difficult.

@cdrini cdrini merged commit 4cda906 into internetarchive:master Dec 21, 2021
@cclauss cclauss deleted the update-infogami-again branch December 21, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 1 Do this week, receiving emails, time sensitive, . [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants