Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix un-html escaped hrefs causing XSS #195

Merged
merged 1 commit into from
May 27, 2022
Merged

Fix un-html escaped hrefs causing XSS #195

merged 1 commit into from
May 27, 2022

Conversation

cdrini
Copy link
Collaborator

@cdrini cdrini commented May 27, 2022

You are allowed to html encode & in urls to & when writing out the href.

Copy link
Collaborator

@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jimchamp jimchamp merged commit b3f8fe6 into master May 27, 2022
@cdrini cdrini deleted the fix/href-xss branch May 27, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants