Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid XSS when writing a hrefs #6597

Merged
merged 1 commit into from
May 27, 2022
Merged

Conversation

cdrini
Copy link
Collaborator

@cdrini cdrini commented May 27, 2022

You are allowed to html encode & in urls to & when writing out the href.

Technical

Testing

Screenshot

Stakeholders

@cdrini cdrini added Patch Deployed This PR has been deployed to production independently, outside of the regular deploy cycle. On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing labels May 27, 2022
@cdrini cdrini marked this pull request as ready for review May 27, 2022 19:22
@jimchamp jimchamp merged commit 988d70e into internetarchive:master May 27, 2022
@cdrini cdrini deleted the fix/href-xss branch May 27, 2022 19:50
@jimchamp jimchamp removed the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Patch Deployed This PR has been deployed to production independently, outside of the regular deploy cycle.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants