Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'Want to Read' Dropper to the Search Inside page #8650

Closed
rishabhkr-r111 opened this issue Dec 20, 2023 · 2 comments · Fixed by #8686
Closed

Add 'Want to Read' Dropper to the Search Inside page #8650

rishabhkr-r111 opened this issue Dec 20, 2023 · 2 comments · Fixed by #8686
Labels
Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Module: Search Page(s) Issues pertaining to the Search page UI Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Reading Log Related to workflows for creating, modifying, displaying a user's reading log. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]

Comments

@rishabhkr-r111
Copy link
Contributor

Add 'Want to Read' Dropper to the Search Inside page as it appears on Books search result page and Authors search result page. Otherwise uses have to navigate to books pages to do so.

Proposal

Dropper can be added below existing borrow button similar to other pages.

image

@mekarpeles Can i work on this issue?
@rishabhkr-r111 rishabhkr-r111 added Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] labels Dec 20, 2023
@mekarpeles mekarpeles added Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Reading Log Related to workflows for creating, modifying, displaying a user's reading log. [managed] Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Module: Search Page(s) Issues pertaining to the Search page UI and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Jan 2, 2024
@sarthakkapila
Copy link
Contributor

Hey @rishabhkr-r111 , I was wondering if you were working on this issue? As I'm really keen on resolving it.

@rishabhkr-r111
Copy link
Contributor Author

@sarthakkapila I am currently working on this issue. I will soon submit a PR request.

@rishabhkr-r111 rishabhkr-r111 mentioned this issue Jan 4, 2024
Merged
jimchamp added a commit that referenced this issue Feb 20, 2024
@jimchamp
Merge pull request #8686 from rishabhkr-r111/8650/fix/Add-Want-to-Rea…
9748930 
…d-Dropper-to-the-Search-Inside-page

Added 'Want to Read' Dropper to the Search Inside page #8650
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Module: Search Page(s) Issues pertaining to the Search page UI Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Reading Log Related to workflows for creating, modifying, displaying a user's reading log. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added 'Want to Read' Dropper to the Search Inside page #8650 rishabhkr-r111/openlibrary
3 participants
@mekarpeles @sarthakkapila @rishabhkr-r111