Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'Want to Read' Dropper to the Search Inside page #8650 #8686

Conversation

rishabhkr-r111
Copy link
Contributor

Closes #8650

Added 'Want to Read' Dropper to the Search Inside page.

Technical

Added 'Want to Read' Dropper to the Search Inside page by importing and adding the dropper component to the calling of the searchResultsWork macro in openlibrary/macros/FulltextResults.html file.

Testing

Screenshot

Stakeholders

importing and adding the dropper component to the calling of the searchResultsWork macro.
@rishabhkr-r111 rishabhkr-r111 marked this pull request as ready for review January 4, 2024 18:36
@rishabhkr-r111 rishabhkr-r111 marked this pull request as draft January 5, 2024 03:36
@jimchamp
Copy link
Collaborator

jimchamp commented Jan 5, 2024

Why is this a draft? I don't understand why so many people are opening draft PRs.

@rishabhkr-r111 rishabhkr-r111 marked this pull request as ready for review January 5, 2024 20:10
@rishabhkr-r111
Copy link
Contributor Author

@jimchamp I Think many people are getting confused due to recent changes made 'HOW TO: Find & Claim a Good First Issue' #8675. Sorry for the confusion I masked it as ready for review.

Copy link
Collaborator

@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rishabhkr-r111, and sorry for the delay. This is working well! I'm going to commit a small change, then merge this work.

openlibrary/macros/FulltextResults.html Outdated Show resolved Hide resolved
openlibrary/macros/FulltextResults.html Outdated Show resolved Hide resolved
@jimchamp jimchamp merged commit 9748930 into internetarchive:master Feb 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'Want to Read' Dropper to the Search Inside page
2 participants