Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable the Integration Tests in xfail mode #3674

Closed
wants to merge 5 commits into from
Closed

Re-enable the Integration Tests in xfail mode #3674

wants to merge 5 commits into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Aug 8, 2020

Instead of getting rid of our Integration Tests as discussed in #2725, let's re-enable them and set the ones that are not working in pytest.mark.xfail mode so that they can be fixed over time.

This approach allows us to keep the eight tests that already work and add new tests to cover the new Python 3 code.

This PR also adds a new Travis CI job to automatically run these user interface tests on all pull requests. The problem is that building the Docker images from scratch takes 8+ minutes on Travis CI so the total job takes 12 minutes! Perhaps this PR should be landed after #3615 so we can reuse that Docker Hub image.

Technical

Testing

The testing steps are discribed at
https://github.com/internetarchive/openlibrary/pull/3674/files#diff-6b1c0422e0532f9de8b00ee73de3d6acR21

Screenshot

Stakeholders

pushd tests/integration
pytest .

================================ test session starts ======================================
platform darwin -- Python 3.8.5, pytest-6.0.1, py-1.9.0, pluggy-0.13.1
rootdir: /Users/cclauss/Python/itinerant_futurizer/openlibrary
collected 44 items

test_affiliate_links.py ..                                                                                                                                                                                                                                                        [  4%]
test_auth.py .xxxxxxxxxxxxxx.xxxxxxx.                                                                                                                                                                                                                                             [ 59%]
test_landing.py xxxxx                                                                                                                                                                                                                                                             [ 70%]
test_loans.py xxx                                                                                                                                                                                                                                                                 [ 77%]
test_microdata.py x.                                                                                                                                                                                                                                                              [ 81%]
test_search.py .xxx                                                                                                                                                                                                                                                               [ 90%]
test_sharing.py xx.x                                                                                                                                                                                                                                                              [100%]

=========================== 8 passed, 36 xfailed in 169.30s (0:02:49) ===========================

@cclauss cclauss added integration Theme: Testing Involves work related to testing infrastructure, development, and ops. [managed] labels Aug 8, 2020
@cclauss cclauss requested review from mekarpeles and cdrini August 8, 2020 23:10
@cclauss cclauss mentioned this pull request Aug 10, 2020
77 tasks
@cclauss cclauss marked this pull request as ready for review August 11, 2020 05:07
@cclauss
Copy link
Contributor Author

cclauss commented Aug 11, 2020

Closed in favor of #3682

@cclauss cclauss closed this Aug 11, 2020
@cclauss cclauss deleted the debug-get_sorted_editions branch August 11, 2020 12:09
@mekarpeles mekarpeles added python Pull requests that update Python code and removed Module: Python labels Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code Theme: Testing Involves work related to testing infrastructure, development, and ops. [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants