-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable the Integration Tests in xfail mode again #3682
Closed
cclauss
wants to merge
10
commits into
internetarchive:master
from
cclauss:re-enable-integration-tests
Closed
Re-enable the Integration Tests in xfail mode again #3682
cclauss
wants to merge
10
commits into
internetarchive:master
from
cclauss:re-enable-integration-tests
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
added
Python
Theme: Testing
Involves work related to testing infrastructure, development, and ops. [managed]
labels
Aug 11, 2020
77 tasks
Update: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
python
Pull requests that update Python code
Theme: Testing
Involves work related to testing infrastructure, development, and ops. [managed]
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does anyone have an instance of 'auth.yaml' on their local disk?
That file was not checked into git but would help use to reconstruct the configuration values.
On HOLD: Pending further progress on Python 3.
Closes #672 #2725 #3674 which got in a bad git state.
Instead of getting rid of our Integration Tests as discussed in #2725, let's re-enable them and set the ones that are not working in
pytest.mark.xfail
mode so that they can be fixed over time.This approach allows us to keep the eight tests that already work and add new tests to cover the new Python 3 code.
This PR also adds a new Travis CI job to automatically run these user interface tests on all pull requests. The problem is that building the Docker images from scratch takes 8+ minutes on Travis CI so the total job takes 12 minutes! Perhaps this PR should be landed after #3615 so we can reuse that Docker Hub image.
Technical
Testing
The testing steps are described at
https://github.com/internetarchive/openlibrary/pull/3674/files#diff-6b1c0422e0532f9de8b00ee73de3d6acR21
Screenshot
Stakeholders
pushd tests/integration
pytest .