Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more German translations and updating i18n Readme #3729

Closed
wants to merge 6 commits into from
Closed

Adding more German translations and updating i18n Readme #3729

wants to merge 6 commits into from

Conversation

bitnapper
Copy link

Closes #

Technical

Testing

Screenshot

Stakeholders

@cdrini cdrini added the On Dev label Aug 26, 2020
@cdrini cdrini self-assigned this Aug 26, 2020
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small fix! I also placed this on dev.openlibrary.org for testing :)

@@ -2185,9 +2193,66 @@ msgstr "(Optional, aber sehr nützlich!)"
#: openlibrary/macros/EditButtons.html:13
msgid ""
"By saving a change to this wiki, you agree that your contribution is given freely to the world under <a href=\"https://"
"creativecommons.org/publicdomain/zero/1.0/\" target=\"_blank\" title=\"This link to Creative Commons will open in a new window"
"creativecommons.org/publicdomain/zero/1.0/\" target=\"_blank\" title=\"Dieser Link aufCreative Commons wird in einem neuen Fenster geöffnet"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the English part :)

Suggested change
"creativecommons.org/publicdomain/zero/1.0/\" target=\"_blank\" title=\"Dieser Link aufCreative Commons wird in einem neuen Fenster geöffnet"
"creativecommons.org/publicdomain/zero/1.0/\" target=\"_blank\" title=\"This link to Creative Commons will open in a new window"

@cdrini
Copy link
Collaborator

cdrini commented Aug 26, 2020

Hmm, it looks like a number of these aren't showing up on the site :/ I think we should merge this (once that fix is added), but if you have the chance, could you try taking a look at the docs on #3725 ? I tried to clean them up / fix them to avoid errors. Would love to see if you can get it working!

@bitnapper
Copy link
Author

Your changes on the readme are very helpful. I made the mistake to read the docker Readme first when I should just have done what is in the i18n readme.

But the i18n-messages seems to create po not meeting the specs. This leads to trouble with the editor. In case of gtranslator it denied me saving my changes until the error was fixed, not telling me which line was causing the error. After running into this trap, there is an easy workaround:

  • execute msgfmt -v -c -o /dev/null messages.po on the original file
  • looking up the affected line and remember the string
  • look up the string with the search in gtranslator and
  • fix the line
  • saving your file

@bitnapper
Copy link
Author

I tried to revert my Version of the README.md not to substitute your. I'm not sure if I did the opposite. So just reject my Version of this file.

@cdrini cdrini removed the On Dev label Oct 19, 2020
@cdrini
Copy link
Collaborator

cdrini commented Oct 21, 2020

Hi @bitnapper ! Sorry for the delay. This PR has become a little tangled 😓 We can't change the msgid strings in the .po files; that's what's used to fetch the translated string. The .po files should only change the msgstr. There have been some conflicts as well now. I think there might be a way to detangle this, though. I'll see if I can find a way 👍

@mekarpeles mekarpeles added the Theme: Internationalization Making OpenLibrary work for both foreign-language users and books. [managed] label Jan 23, 2021
@mekarpeles mekarpeles added this to the Active Sprint milestone Feb 24, 2021
@cdrini cdrini modified the milestones: Sprint 2021-02, Active Sprint Mar 1, 2021
@mekarpeles mekarpeles assigned jimchamp and unassigned cdrini Nov 22, 2021
@mekarpeles mekarpeles added the Priority: 2 Important, as time permits. [managed] label Apr 4, 2022
@mekarpeles
Copy link
Member

I think the right solution is for us to basically clobber all changes except for the de ones and play those on top of master; I think @jimchamp is on this when there's time.

ty!

@mekarpeles mekarpeles removed this from the Next (proposed) milestone Apr 4, 2022
@cdrini cdrini self-assigned this Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 2 Important, as time permits. [managed] Theme: Internationalization Making OpenLibrary work for both foreign-language users and books. [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants