-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding more German translations and updating i18n Readme #3729
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small fix! I also placed this on dev.openlibrary.org for testing :)
openlibrary/i18n/de/messages.po
Outdated
@@ -2185,9 +2193,66 @@ msgstr "(Optional, aber sehr nützlich!)" | |||
#: openlibrary/macros/EditButtons.html:13 | |||
msgid "" | |||
"By saving a change to this wiki, you agree that your contribution is given freely to the world under <a href=\"https://" | |||
"creativecommons.org/publicdomain/zero/1.0/\" target=\"_blank\" title=\"This link to Creative Commons will open in a new window" | |||
"creativecommons.org/publicdomain/zero/1.0/\" target=\"_blank\" title=\"Dieser Link aufCreative Commons wird in einem neuen Fenster geöffnet" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the English part :)
"creativecommons.org/publicdomain/zero/1.0/\" target=\"_blank\" title=\"Dieser Link aufCreative Commons wird in einem neuen Fenster geöffnet" | |
"creativecommons.org/publicdomain/zero/1.0/\" target=\"_blank\" title=\"This link to Creative Commons will open in a new window" |
Hmm, it looks like a number of these aren't showing up on the site :/ I think we should merge this (once that fix is added), but if you have the chance, could you try taking a look at the docs on #3725 ? I tried to clean them up / fix them to avoid errors. Would love to see if you can get it working! |
Your changes on the readme are very helpful. I made the mistake to read the docker Readme first when I should just have done what is in the i18n readme. But the i18n-messages seems to create po not meeting the specs. This leads to trouble with the editor. In case of gtranslator it denied me saving my changes until the error was fixed, not telling me which line was causing the error. After running into this trap, there is an easy workaround:
|
I tried to revert my Version of the README.md not to substitute your. I'm not sure if I did the opposite. So just reject my Version of this file. |
Hi @bitnapper ! Sorry for the delay. This PR has become a little tangled 😓 We can't change the |
I think the right solution is for us to basically clobber all changes except for the ty! |
Closes #
Technical
Testing
Screenshot
Stakeholders