Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply bitnapper's German translation fixes #6390

Merged
merged 3 commits into from
Apr 12, 2022
Merged

Conversation

cdrini
Copy link
Collaborator

@cdrini cdrini commented Apr 6, 2022

Closes #3729 . This adds just the German additions to the messages.po file ; any changes to the strings were too difficult to untangle for me, so I just chose to use the default where available. This added ~1% coverage to our German translations! Some of the added strings are no longer part of our HTML unfortunately, but I they'll be handled correctly next time we regen the .po files.

Technical

I found some useful commands! Here's what I ran. I downloaded the final messages.po from #3729 , and then used a gettext function called msgcat to concatenate the two po files, choosing translations from the current master branch in cases where there was a conflict:

docker-compose run -u root --rm --no-deps web bash -c "
    apt-get update && apt-get install -y gettext
    su openlibrary -c '
        msgcat --width=83 --use-first openlibrary/i18n/de/messages.po openlibrary/i18n/de/messages2.po > openlibrary/i18n/de/merged.po
    '
"

I then moved the merged file over to messages.po, and did some manual cleanup where things were funny or it had introduced arbitrary newlines.

Testing

Screenshot

Stakeholders

@bitnapper @jimchamp

Thorsten Alge and others added 3 commits April 5, 2022 21:29
Copy link
Collaborator

@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@jimchamp jimchamp merged commit 8f62364 into internetarchive:master Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants