Apply bitnapper's German translation fixes #6390
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3729 . This adds just the German additions to the messages.po file ; any changes to the strings were too difficult to untangle for me, so I just chose to use the default where available. This added ~1% coverage to our German translations! Some of the added strings are no longer part of our HTML unfortunately, but I they'll be handled correctly next time we regen the .po files.
Technical
I found some useful commands! Here's what I ran. I downloaded the final
messages.po
from #3729 , and then used agettext
function calledmsgcat
to concatenate the two po files, choosing translations from the current master branch in cases where there was a conflict:I then moved the merged file over to messages.po, and did some manual cleanup where things were funny or it had introduced arbitrary newlines.
Testing
Screenshot
Stakeholders
@bitnapper @jimchamp