Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] refactor: Reformat the openlibrary/ directory with black #5079

Closed

Conversation

dhruvmanila
Copy link
Collaborator

@dhruvmanila dhruvmanila commented Apr 21, 2021

Subtask of #4776

Run black on only openlibrary/ directory:

> black --skip-string-normalization openlibrary/

TODO:

Closes #

Technical

Testing

Screenshot

Stakeholders

@cclauss @cdrini

@dhruvmanila dhruvmanila marked this pull request as draft April 21, 2021 13:39
@dhruvmanila dhruvmanila changed the title refactor: Reformat the entire codebase with black [WIP] refactor: Reformat the entire codebase with black Apr 21, 2021
@dhruvmanila dhruvmanila marked this pull request as ready for review May 4, 2021 05:09
Makefile Outdated Show resolved Hide resolved
@cclauss cclauss changed the title [WIP] refactor: Reformat the entire codebase with black [WIP] refactor: Reformat the openlibrary/ directory with black May 4, 2021
@cclauss
Copy link
Contributor

cclauss commented May 4, 2021

--max-line-length=1195

openlibrary/utils/olcompress.py:10:89: E501 line too long (1195 > 88 characters)

@dhruvmanila
Copy link
Collaborator Author

Hey, @cdrini Can you please take a look at why the tests are failing? https://github.com/internetarchive/openlibrary/pull/5079/checks?check_run_id=2498124543#step:8:124

This function was added by you so you would know more about it :)

@cdrini cdrini marked this pull request as draft May 10, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants