Remove black option --diff #6594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
changed the title
cclauss
force-pushed
the
remove_black_option_--diff_again
branch
from
eb549c8 to
35400a3
Compare
cclauss
force-pushed
the
remove_black_option_--diff_again
branch
from
aed7811 to
410f6a2
Compare
cclauss
force-pushed
the
remove_black_option_--diff_again
branch
from
e99a734 to
410f6a2
Compare
This was referenced May 28, 2022
Closed
cclauss
force-pushed
the
remove_black_option_--diff_again
branch
from
7a4a206 to
df4fd16
Compare
cclauss
force-pushed
the
remove_black_option_--diff_again
branch
from
39fa537 to
e16adf4
Compare
cclauss
force-pushed
the
remove_black_option_--diff_again
branch
from
48fa6b8 to
ce03f52
Compare
cclauss
force-pushed
the
remove_black_option_--diff_again
branch
from
28e42e4 to
cd51b14
Compare
cclauss
force-pushed
the
remove_black_option_--diff_again
branch
3 times, most recently
from
9bb4163 to
9205b8c
Compare
|
OK, Now this PR only modifies two files to make it easy to review and merge.
|
This was referenced Jul 1, 2022
cclauss
force-pushed
the
remove_black_option_--diff_again
branch
from
9205b8c to
8b6a0d3
Compare
cclauss
force-pushed
the
remove_black_option_--diff_again
branch
from
375864f to
20a5d8b
Compare
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the last remains tasks of #4776
Closes #5079
Remove --diff option which currently prevents black from re-formatting modified Python files.
I only made changes to
.pre-commit-config.yaml. Pre-commit CI automatically made the changes to all other files.After Slacking with @mekarpeles, we will move the following question to a separate PR.
Question: If we are going to modify 40 Python files, given #2981 (comment) should we modify even more by:
--skip-string-normalizationand allowing black to favor double-quoted strings in Python code. -- OR --Adding double-quote-string-fixer to prefer single-quotes in Python files instead of black-standard double-quotes. See: pre-commit: Should we favor single quoted strings in Python? #6602Technical
Once this is landed we should establish a flake8 baseline against:
flake8 **/*.py --exclude="./.*,./vendor/*" --ignore=E203,W503 --max-complexity=41 --max-line-length=1195Testing
Screenshot
Stakeholders