all the unused imports are removed #5555
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that #3483 (comment) will still be the case. |
hornc
reviewed
Aug 17, 2021
| @@ -20,7 +20,7 @@ | |||
| from openlibrary.core.vendors import create_edition_from_amazon_metadata | |||
|
|
|||
| # Seed might look unused, but removing it causes an error :/ | |||
There was a problem hiding this comment.
this comment looks relevant:
# Seed might look unused, but removing it causes an error :/
I believe there are unfortunately a number of cases in older OL code where things are imported in a file to be used elsewhere and it's not indicated clearly that the module is supposed to provide that interface.
|
Closing as stale; feel free to re-open if you have the time to work on it, @sharmas1ddharth ! I'd recommend targeting smaller chunks at a time; say max 10 files a PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3483
refactor
Technical
I have removed all the unused imports or libraries and declutters the code
Testing
Screenshot
This PR does not touches UI
Stakeholders
@cclauss @imskr