all the unused imports are removed

openlibrary/app.py

@@ -21,7 +21,6 @@ def GET(self, name):
     # In infogami, the class with this functionality is called page.
     # We are redefining with a slightly different terminology to make
     # things more readable.
-    pass
 
 # view is just a base class.
 # Defining a class extending from _app.page auto-registers it inside infogami.

openlibrary/catalog/add_book/__init__.py

@@ -22,7 +22,6 @@
     response = load(record)
 
 """
-import json
 import re
 
 import unicodedata as ucd

openlibrary/catalog/marc/marc_subject.py

@@ -15,8 +15,7 @@
 from openlibrary.catalog.get_ia import get_from_archive, marc_formats, urlopen_keep_trying
 from openlibrary.catalog.marc import get_subjects
 from openlibrary.catalog.marc.marc_binary import MarcBinary
-from openlibrary.catalog.marc.marc_xml import read_marc_file, MarcXml, BlankTag, BadSubtag
-from openlibrary.catalog.utils import remove_trailing_dot, remove_trailing_number_dot, flip_name
+from openlibrary.catalog.marc.marc_xml import MarcXml
 
 
 subject_fields = set(['600', '610', '611', '630', '648', '650', '651', '662'])

openlibrary/code.py

@@ -33,7 +33,6 @@ def setup():
     load_views()
 
     # load actions
-    from . import actions
 
     logger.info("loading complete.")
 
@@ -51,7 +50,5 @@ def setup_logging():
 def load_views():
     """Registers all views by loading all view modules.
     """
-    from .views import showmarc
-    from .views import loanstats
 
 setup()

openlibrary/core/lists/model.py

@@ -6,17 +6,13 @@
 import web
 import logging
 
-from infogami import config
-from infogami.infobase import client, common
-from infogami.utils import stats
 
 from openlibrary.core import helpers as h
 from openlibrary.core import cache
 
 from openlibrary.plugins.worksearch.search import get_solr
 
 import six
-from six.moves import urllib
 
 
 logger = logging.getLogger("openlibrary.lists.model")

openlibrary/core/models.py

@@ -20,7 +20,7 @@
 from openlibrary.core.vendors import create_edition_from_amazon_metadata
 
 # Seed might look unused, but removing it causes an error :/
-from openlibrary.core.lists.model import ListMixin, Seed
+from openlibrary.core.lists.model import ListMixin
 from . import cache, waitinglist
 
 from six.moves import urllib

openlibrary/core/observations.py

@@ -4,7 +4,6 @@
 
 from infogami import config
 from infogami.utils.view import public
-from openlibrary import accounts
 from openlibrary.utils import extract_numeric_id_from_olid
 
 from . import cache

openlibrary/core/processors/__init__.py

@@ -1 +0,0 @@
-from openlibrary.core.processors.readableurls import ReadableUrlProcessor

openlibrary/core/sponsorships.py

@@ -3,7 +3,6 @@
 import requests
 import web
 
-from six.moves.urllib.parse import urlencode
 
 from collections import OrderedDict
 from infogami.utils.view import public
@@ -12,7 +11,7 @@
     get_betterworldbooks_metadata,
     get_amazon_metadata)
 from openlibrary import accounts
-from openlibrary.accounts.model import get_internet_archive_id, sendmail
+from openlibrary.accounts.model import get_internet_archive_id
 from openlibrary.core.civicrm import (
     get_contact_id_by_username,
     get_sponsorships_by_contact_id,

openlibrary/core/vendors.py

@@ -249,7 +249,6 @@ def search_amazon(title='', author=''):
     :return: dict of "results", a list of one or more found books, with metadata.
     :rtype: dict
     """
-    pass
 
 
 def _get_amazon_metadata(id_, id_type='isbn', resources=None):

openlibrary/core/waitinglist.py

@@ -142,7 +142,6 @@ def delete(self):
         """
         #db.delete("waitingloan", where="id=$id", vars=self)
         _wl_api.leave_waitinglist(self['identifier'], self['userid'])
-        pass
 
     def update(self, **kw):
         #db.update("waitingloan", where="id=$id", vars=self, **kw)

openlibrary/coverstore/archive.py

@@ -7,7 +7,6 @@
 import time
 
 from openlibrary.coverstore import config, db
-from openlibrary.coverstore.coverlib import find_image_path
 
 import six
 

openlibrary/coverstore/code.py

@@ -6,7 +6,6 @@
 import logging
 import os
 
-import memcache
 import requests
 import web
 
@@ -17,8 +16,6 @@
     download,
     ol_get,
     ol_things,
-    random_string,
-    rm_f,
     safeint,
 )
 from openlibrary.plugins.openlibrary.processors import CORSProcessor

openlibrary/data/sitemap.py

@@ -20,7 +20,6 @@
 import datetime
 from gzip import open as gzopen
 
-from openlibrary.plugins.openlibrary.processors import urlsafe
 
 t = web.template.Template
 

openlibrary/i18n/__init__.py

@@ -13,7 +13,7 @@
 from babel.messages import Catalog
 from babel.messages.pofile import read_po, write_po
 from babel.messages.mofile import write_mo
-from babel.messages.extract import extract_from_file, extract_from_dir, extract_python
+from babel.messages.extract import extract_from_dir, extract_python
 
 root = os.path.dirname(__file__)
 

openlibrary/plugins/admin/code.py

@@ -9,7 +9,6 @@
 import traceback
 import logging
 import json
-import yaml
 
 from infogami import config
 from infogami.utils import delegate
@@ -25,14 +24,13 @@
 
 from openlibrary import accounts
 
-from openlibrary.core import lending, admin as admin_stats, helpers as h, imports, cache
+from openlibrary.core import admin as admin_stats, cache, helpers as h, imports
 from openlibrary.core.waitinglist import Stats as WLStats
 from openlibrary.core.sponsorships import (
     summary, sync_completed_sponsored_books)
 
 from openlibrary.plugins.upstream import forms, spamcheck
 from openlibrary.plugins.upstream.account import send_forgot_password_email
-from openlibrary.plugins.admin import services
 
 
 logger = logging.getLogger("openlibrary.admin")

openlibrary/plugins/admin/mem.py

@@ -1,4 +1,3 @@
-from infogami.utils import delegate
 from infogami.utils.view import render, safeint
 from openlibrary.plugins.admin import memory
 import web

openlibrary/plugins/books/readlinks.py

@@ -10,7 +10,6 @@
 import web
 from openlibrary.core import ia
 from openlibrary.core import helpers
-from openlibrary.api import OpenLibrary
 from openlibrary.plugins.books import dynlinks
 from infogami.utils.delegate import register_exception
 from infogami.utils import stats

openlibrary/plugins/importapi/tests/test_code_ils.py

@@ -1,6 +1,5 @@
 import datetime
 from openlibrary.plugins.importapi import code
-from openlibrary.mocks.mock_infobase import MockSite
 """Tests for Koha ILS (Integrated Library System) code.
 """
 

openlibrary/plugins/openlibrary/api.py

@@ -9,17 +9,13 @@
 import json
 from collections import defaultdict
 
-from infogami import config
 from infogami.utils import delegate
 from infogami.utils.view import render_template  # noqa: F401 used for its side effects
 from infogami.plugins.api.code import jsonapi
-from infogami.utils.view import add_flash_message
 from openlibrary import accounts
 from openlibrary.utils.isbn import isbn_10_to_isbn_13, normalize_isbn
 from openlibrary.utils import extract_numeric_id_from_olid
-from openlibrary.plugins.worksearch.subjects import get_subject
-from openlibrary.accounts.model import OpenLibraryAccount
-from openlibrary.core import ia, db, models, lending, helpers as h
+from openlibrary.core import helpers as h, lending, models
 from openlibrary.core.observations import Observations
 from openlibrary.core.models import Booknotes, Work
 from openlibrary.core.sponsorships import qualifies_for_sponsorship

openlibrary/plugins/openlibrary/code.py

@@ -29,7 +29,6 @@
 from infogami.core.db import ValidationException
 
 from openlibrary.core import cache
-from openlibrary.core.vendors import create_edition_from_amazon_metadata
 from openlibrary.utils.isbn import isbn_13_to_isbn_10, isbn_10_to_isbn_13
 from openlibrary.core.models import Edition  # noqa: E402
 from openlibrary.core.lending import get_work_availability, get_edition_availability
@@ -244,7 +243,6 @@ def POST(self):
 
 class clonebook(delegate.page):
     def GET(self):
-        from infogami.core.code import edit
         i = web.input('key')
         page = web.ctx.site.get(i.key)
         if page is None:
@@ -941,7 +939,6 @@ def setup():
     status.setup()
     authors.setup()
 
-    from openlibrary.plugins.openlibrary import api
     delegate.app.add_processor(web.unloadhook(stats.stats_hook))
 
     if infogami.config.get('dev_instance') is True:

openlibrary/plugins/openlibrary/connection.py

@@ -1,7 +1,7 @@
 """Open Library extension to provide a new kind of client connection with caching support.
 """
 from infogami import config
-from infogami.infobase import client, lru
+from infogami.infobase import client
 from infogami.utils import stats
 
 import web

openlibrary/plugins/openlibrary/design.py

@@ -1,9 +1,8 @@
 
-import web
 import logging
 
 from infogami.utils import delegate
-from infogami.utils.view import render_template, public
+from infogami.utils.view import render_template
 
 logger = logging.getLogger("openlibrary.design")
 

openlibrary/plugins/openlibrary/home.py

@@ -8,7 +8,6 @@
 from infogami.utils import delegate
 from infogami.utils.view import render_template, public
 from infogami.infobase.client import storify
-from infogami import config
 
 from openlibrary.core import admin, cache, ia, lending, \
     helpers as h

openlibrary/plugins/openlibrary/lists.py

@@ -12,7 +12,6 @@
 
 from openlibrary.core import formats, cache
 import openlibrary.core.helpers as h
-from openlibrary.utils import dateutil
 from openlibrary.plugins.upstream import spamcheck
 from openlibrary.plugins.worksearch import subjects
 

openlibrary/plugins/openlibrary/processors.py

@@ -2,7 +2,6 @@
 """
 import web
 
-from openlibrary.core.processors import ReadableUrlProcessor
 import six
 
 from openlibrary.core import helpers as h

openlibrary/plugins/openlibrary/stats.py

@@ -14,7 +14,6 @@
 import web
 from infogami import config
 from infogami.utils import (
-    delegate,
     stats,
 )
 

openlibrary/plugins/openlibrary/tests/test_home.py

@@ -1,17 +1,12 @@
 import datetime
-import pytest
 import web
 
-from infogami.utils.view import render_template
-from infogami.utils import template, context
-from openlibrary.i18n import gettext
 from openlibrary.core.admin import Stats
 from openlibrary.mocks.mock_infobase import MockSite
 from bs4 import BeautifulSoup
 
 import six
 
-from openlibrary import core
 from openlibrary.plugins.openlibrary import home
 
 class MockDoc(dict):

openlibrary/plugins/openlibrary/tests/test_listapi.py

@@ -1,6 +1,4 @@
 from __future__ import print_function
-from py.test import config
-import web
 import json
 
 import cookielib

openlibrary/plugins/openlibrary/tests/test_ratingsapi.py

@@ -1,11 +1,8 @@
-from py.test import config
-import web
 import json
 
 import cookielib
 from six.moves import urllib
 
-from openlibrary.plugins.openlibrary.api import ratings
 from openlibrary import accounts
 from openlibrary.core import models
 

openlibrary/plugins/openlibrary/utils.py

@@ -1 +0,0 @@
-from openlibrary.core.helpers import sanitize

openlibrary/plugins/upstream/account.py

@@ -11,25 +11,22 @@
 )
 
 from infogami.infobase.client import ClientException
-from infogami.utils.context import context
 from infogami.utils.view import safeint
-import infogami.core.code as core
 
 from openlibrary import accounts
 from openlibrary.i18n import gettext as _
-from openlibrary.core import helpers as h, lending
+from openlibrary.core import lending
 from openlibrary.core.booknotes import Booknotes
 from openlibrary.core.bookshelves import Bookshelves
 from openlibrary.core.observations import Observations, convert_observation_ids
 from openlibrary.plugins.recaptcha import recaptcha
 from openlibrary.plugins import openlibrary as olib
 from openlibrary.accounts import (
-    audit_accounts, Account, OpenLibraryAccount, InternetArchiveAccount, valid_email)
+    audit_accounts, OpenLibraryAccount, InternetArchiveAccount, valid_email)
 from openlibrary.core.sponsorships import get_sponsored_editions
 from openlibrary.plugins.upstream import borrow, forms, utils
 
 from six.moves import range
-from six.moves import urllib
 
 
 logger = logging.getLogger("openlibrary.account")
@@ -276,7 +273,6 @@ def POST(self):
         payload is json. Instead, if login attempted w/ json
         credentials, requires Archive.org s3 keys.
         """
-        from openlibrary.plugins.openlibrary.code import BadRequest
         d = json.loads(web.data())
         access = d.get('access', None)
         secret = d.get('secret', None)

openlibrary/plugins/upstream/addbook.py

@@ -6,16 +6,13 @@
 import datetime
 
 from infogami import config
-from infogami.core import code as core
 from infogami.core.db import ValidationException
 from infogami.utils import delegate
 from infogami.utils.view import safeint, add_flash_message
 from infogami.infobase.client import ClientException
 
-from openlibrary.plugins.openlibrary.processors import urlsafe
 from openlibrary.plugins.worksearch.search import get_solr
 from openlibrary.utils import is_author_olid, is_work_olid
-from openlibrary.i18n import gettext as _
 from openlibrary import accounts
 import logging
 
@@ -1049,4 +1046,3 @@ def POST(self, edition):
 
 def setup():
     """Do required setup."""
-    pass