Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate subjects #6250

Closed
wants to merge 1 commit into from
Closed

Conversation

mekarpeles
Copy link
Member

@mekarpeles mekarpeles commented Mar 6, 2022

merges duplicate subject sections -- take the full/complete list of subject tags and moves them up to section above the fold (replacing the abridged version in the overview). The complete subjects are show within a "show more" area.

i.e.

https://testing.openlibrary.org/works/OL17991110W/Puerto_Rican_women%27s_history

openlibrary org_works_OL17991110W_Puerto_Rican_women%27s_history

Gets substituted with this full content (which then is removed from the below section):

openlibrary org_works_OL17991110W_Puerto_Rican_women%27s_history (1)

Stakeholders

@mekarpeles mekarpeles added Affects: Experience Issues relating directly to service design & patrons experience Affects: UI Issues with the web site's user interface. [managed] Module: Books Page On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing labels Mar 6, 2022
@mekarpeles mekarpeles assigned cdrini and unassigned jimchamp Mar 7, 2022
@mekarpeles
Copy link
Member Author

mekarpeles commented Mar 7, 2022

cc: @mheiman + @jimchamp

@cdrini and I discussed; the plan seems like we'll remove all subjects/times/people to above the fold and by default render as

.clamp {
    display: -webkit-box;
    -webkit-box-orient: vertical;
    -webkit-line-clamp: 1; // in the future, this could be used for edition.description + increase to e.g. 5
    overflow: hidden;
}

The Read More logic will include a toggle of overflow: hidden for any child that has .clamp.

Note This will not use the existing Read More code, it will use a new js function which simply toggles overflow for children w/ .clamp

We'll have to add this to our site template (e.g. header) so the site works for folks w/o js

<noscript>
    <style>.clamp { -webkit-line-clamp: unset !important }</style>
</noscript>
  • We'll remove subjects duplicate from the Work section

testing openlibrary org_works_OL17449W_King_Solomon's_Mines

@mekarpeles
Copy link
Member Author

@jimchamp can we turn this into a new issue which is Needs: Help + Good First Issue and see if someone from the community is willing to help?

@mekarpeles mekarpeles added the State: Blocked Work has stopped, waiting for something (Info, Dependent fix, etc. See comments). [managed] label Mar 7, 2022
@mekarpeles
Copy link
Member Author

Supplanted by #6265

@mekarpeles mekarpeles closed this Mar 8, 2022
@jimchamp jimchamp removed the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: Experience Issues relating directly to service design & patrons experience Affects: UI Issues with the web site's user interface. [managed] Module: Books Page State: Blocked Work has stopped, waiting for something (Info, Dependent fix, etc. See comments). [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants