Moving subjects up, show more, nojs #6265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mekarpeles
force-pushed
the
consolidate-subjects
branch
from
344fe0b to
a4db1a0
Compare
mekarpeles
commented
Mar 8, 2022
mekarpeles
commented
Mar 8, 2022
mekarpeles
commented
Mar 8, 2022
mekarpeles
commented
Mar 8, 2022
Closed
- show + to denote expandable sections - visual accents on omnibar - adjust editions table padding - move some options below table (better packing)
mekarpeles
force-pushed
the
consolidate-subjects
branch
from
b8dca31 to
2d8dfb8
Compare
jimchamp
reviewed
Mar 9, 2022
jimchamp
reviewed
Mar 9, 2022
jimchamp
approved these changes
Mar 9, 2022
There was a problem hiding this comment.
Lgtm! Will merge into book page integration branch.
Some things we may want to add before merging into main:
- Changing the cursor to
pointerwhen hovering over the+ - Somehow make it more clear that subjects are fully expanded (it's somewhat difficult to tell when all of the subjects span a single line).
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supplants #6250
Technical
Testing
Screenshot
Stakeholders