Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert some Python type comments to type hints #6320

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Mar 20, 2022

Convert Python type comments to type hints
Avoid solr related files because of Cython.

Technical

Testing

Screenshot

Stakeholders

@cclauss cclauss added Module: Python python Pull requests that update Python code labels Mar 20, 2022
@cclauss cclauss requested a review from cdrini March 20, 2022 12:20
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mypy passes ; lgtm! Not testing otherwise.

@cdrini cdrini self-assigned this Mar 21, 2022
@cdrini cdrini merged commit 6d37cbf into internetarchive:master Mar 21, 2022
@cdrini cdrini changed the title Convert Python type comments to type hints Convert some Python type comments to type hints Mar 21, 2022
@cclauss cclauss deleted the Upgrade-type-comments branch March 21, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants