-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vendors: Retry getting Amazon data from the affiliate server #6332
Merged
mekarpeles
merged 3 commits into
internetarchive:master
from
cclauss:amazon_retry_before_submit
May 2, 2022
Merged
Vendors: Retry getting Amazon data from the affiliate server #6332
mekarpeles
merged 3 commits into
internetarchive:master
from
cclauss:amazon_retry_before_submit
May 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you search the history to see if we can do |
Did you mean to close this PR? #6320 says that the type hints thing is about Cython use in Solr. Also see: |
Ooops!!! No I did not meant to close it :P |
cclauss
commented
Apr 7, 2022
Test this on one of the VMs like
|
mekarpeles
changed the title
DRAFT: Vendors: Retry getting Amazon data from the affiliate server
Vendors: Retry getting Amazon data from the affiliate server
Apr 7, 2022
Co-authored-by: Christian Clauss <cclauss@me.com>
Ready for review. |
mekarpeles
added
the
On testing.openlibrary.org
This PR has been deployed to testing.openlibrary.org for testing
label
Apr 21, 2022
jimchamp
removed
the
On testing.openlibrary.org
This PR has been deployed to testing.openlibrary.org for testing
label
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5474
The /isbn endpoint should retry a few times to see if the affiliate service has the Amazon result in the cache. If this import is already queued up, the set operation will ensure that it will be ignored automatically.
Technical
Testing
Screenshot
Stakeholders