[Bug Fix] Prevent the expanding/collapsing of the subject area when the link is being clicked #6445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…simultaneously-collapse-the-subject-area
…ubject-area' of github.com:Philippos01/openlibrary into 6361/Bug-Fix/subject-tags-simultaneously-collapse-the-subject-area
for more information, see https://pre-commit.ci
…ubject-area' of github.com:Philippos01/openlibrary into 6361/Bug-Fix/subject-tags-simultaneously-collapse-the-subject-area
for more information, see https://pre-commit.ci
jimchamp
reviewed
Apr 19, 2022
jimchamp
reviewed
Apr 19, 2022
jimchamp
reviewed
Apr 19, 2022
jimchamp
requested changes
Apr 19, 2022
jimchamp
added
the
Needs: Submitter Input
Co-authored-by: jimchamp <jameschamp@acm.org>
Co-authored-by: jimchamp <jameschamp@acm.org>
Co-authored-by: jimchamp <jameschamp@acm.org>
Co-authored-by: jimchamp <jameschamp@acm.org>
|
@jimchamp we commited the proposed changes. |
…simultaneously-collapse-the-subject-area
for more information, see https://pre-commit.ci
…ubject-area' of github.com:Philippos01/openlibrary into 6361/Bug-Fix/subject-tags-simultaneously-collapse-the-subject-area
cdrini
removed
the
Needs: Submitter Input
cdrini
approved these changes
Apr 20, 2022
|
Talked with @jimchamp ; taking this to try to get it in today's deploy 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6361
With this fix, we achieve preventing collapsing and expanding of the subject area while a link from the
atag in being clicked.Technical
We attached to the jQuery click event handler an argument in order to check if the nodeName of the tag is
a. If this is true, there is no need to expand/collapse and the user should be redirected to the corresponding page.Testing
On the book page, click a link on the Subjects, People or Pages. The list expands which is an incorrect behavior before redirecting.
Screenshot
book-page-subjects-not-expanding.mp4
Stakeholders
@cdrini
@jimchamp
Attribution Disclaimer: By proposing this pull request, I affirm to have made a best-effort and exercised my discretion to make sure relevant sections of this code which substantially leverage code suggestions, code generation, or code snippets from sources (e.g. Stack Overflow, GitHub) have been annotated with basic attribution so reviewers & contributors may have confidence and access to the correct context to evaluate and use this code.