Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform further unit testing in the readmore.js file #6467

Conversation

Philippos01
Copy link
Contributor

Closes #6461

It achieves further testing on the initClampers function covering most of its lines(except line: 59). Specifically it tests the pull request #6445 which fixes the subject area expanding/collapsing problem when an anchor tag is being clicked.

Technical

It is using jest to perform the mocking and the function trigger('click') to create a click event.

Screenshot

image

Stakeholders

@cdrini
@jimchamp

@Philippos01 Philippos01 changed the title 6461/testing/additional tests at readmore.js Perform further unit testing in the readmore.js file Apr 22, 2022
@cdrini cdrini self-assigned this Apr 22, 2022
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Lgtm; a few small naming things.

tests/unit/js/html-test-data.js Outdated Show resolved Hide resolved
tests/unit/js/readmore.test.js Outdated Show resolved Hide resolved
tests/unit/js/readmore.test.js Outdated Show resolved Hide resolved
tests/unit/js/readmore.test.js Outdated Show resolved Hide resolved
tests/unit/js/readmore.test.js Outdated Show resolved Hide resolved
@cdrini cdrini merged commit 89e7746 into internetarchive:master Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Perform unit test on initClampers function in the readmore.js
3 participants