Refactor get_ebook_info to explicitly take IA metadata #6563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrini
force-pushed
the
refactor/get_ebook_info
branch
3 times, most recently
from
05ba627 to
5572147
Compare
cdrini
changed the title
cdrini
force-pushed
the
refactor/get_ebook_info
branch
from
5572147 to
06ae5cc
Compare
This was referenced May 20, 2022
mekarpeles
added
the
Priority: 1
This was referenced May 27, 2022
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #6564 and #6379 . Having the ia metadata be implicit was making it difficult to generalize for different trusted book providers (See WIP pr #6559)
Technical
Testing
Screenshot
Stakeholders